[fix] Auto-install script: fixed disabling OpenVPN #490 #518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When user selects 'n' to disable OpenVPN during auto-install, the script was setting VPN_DOMAIN to "example.com" instead of an empty string. This caused the OpenVPN container to still start and fail on systems without /dev/net/tun device. The existing logic in init_command.sh already handles this case by exiting when VPN_DOMAIN is empty. This change ensures the variable is properly set to empty when OpenVPN is disabled. Fixes openwisp#490
Adityashandilya555
force-pushed
the
issues/490-openvpn-disable-fix
branch
from
4f3f1eb to
244e196
Compare
…penwisp#490 Replace bash 4.0+ specific syntax with explicit case checking to ensure compatibility with older bash versions. The parameter expansion syntax is not supported in bash 3.x, causing uppercase 'N' option to fail. Fixes case sensitivity issue where prompt shows 'N' but only lowercase 'n' was accepted on systems with bash versions prior to 4.0.
nemesifier
changed the title
nemesifier
reviewed
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When user selects 'n' to disable OpenVPN during auto-install, the script was setting VPN_DOMAIN to "example.com" instead of an empty string. This caused the OpenVPN container to still start and fail on systems without /dev/net/tun device.
Checklist
Reference to Existing Issue
Closes #490
Please open a new issue if there isn't an existing issue yet.
Description of Changes
The existing logic in init_command.sh already handles this case by exiting when VPN_DOMAIN is empty. This change ensures the variable is properly set to empty when OpenVPN is disabled.
Screenshot
Please include any relevant screenshots.