Skip to content

fix(core): fix numalgo 2 DID exchange by using correct service class#2757

Merged
genaris merged 1 commit intoopenwallet-foundation:feat/didcomm-v2from
tarunvaddeSoul:fix/didcomm-v2-ci-fixes
Apr 17, 2026
Merged

fix(core): fix numalgo 2 DID exchange by using correct service class#2757
genaris merged 1 commit intoopenwallet-foundation:feat/didcomm-v2from
tarunvaddeSoul:fix/didcomm-v2-ci-fixes

Conversation

@tarunvaddeSoul
Copy link
Copy Markdown
Contributor

Summary

  • didToNumAlgo2DidDocument was creating all services as base DidDocumentService instances instead of their proper subclass (e.g. DidCommV1Service), causing instanceof checks to fail
  • This meant DidDocument.recipientKeys returned zero keys for numalgo 2 DIDs, breaking DID exchange when the requester uses numalgo 2
  • Fix: use the existing serviceTypes mapping (same as ServiceTransformer) to instantiate the correct service class

Test plan

  • All 8 didexchange-numalgo tests pass (2 were timing out before)
  • peerDidNumAlgo2 resolution tests pass (fixture updated for priority field)
  • pnpm types:check clean
  • pnpm style:check clean

Signed-off-by: Tarun Vadde <vaddeofficial@gmail.com>
@tarunvaddeSoul tarunvaddeSoul requested a review from a team as a code owner April 17, 2026 16:02
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 17, 2026

⚠️ No Changeset found

Latest commit: 8c3140f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@genaris genaris merged commit c12e7df into openwallet-foundation:feat/didcomm-v2 Apr 17, 2026
8 checks passed
@tarunvaddeSoul tarunvaddeSoul deleted the fix/didcomm-v2-ci-fixes branch April 17, 2026 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants