fix(core): fix numalgo 2 DID exchange by using correct service class#2757
Merged
genaris merged 1 commit intoopenwallet-foundation:feat/didcomm-v2from Apr 17, 2026
Conversation
Signed-off-by: Tarun Vadde <vaddeofficial@gmail.com>
|
genaris
approved these changes
Apr 17, 2026
c12e7df
into
openwallet-foundation:feat/didcomm-v2
8 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
didToNumAlgo2DidDocumentwas creating all services as baseDidDocumentServiceinstances instead of their proper subclass (e.g.DidCommV1Service), causinginstanceofchecks to failDidDocument.recipientKeysreturned zero keys for numalgo 2 DIDs, breaking DID exchange when the requester uses numalgo 2serviceTypesmapping (same asServiceTransformer) to instantiate the correct service classTest plan
didexchange-numalgotests pass (2 were timing out before)peerDidNumAlgo2resolution tests pass (fixture updated forpriorityfield)pnpm types:checkcleanpnpm style:checkclean