Skip to content

ci: run tests on node 22 and 24 (drop 20)#2754

Merged
genaris merged 2 commits intoopenwallet-foundation:mainfrom
genaris:ci/test-on-24
Apr 20, 2026
Merged

ci: run tests on node 22 and 24 (drop 20)#2754
genaris merged 2 commits intoopenwallet-foundation:mainfrom
genaris:ci/test-on-24

Conversation

@genaris
Copy link
Copy Markdown
Contributor

@genaris genaris commented Apr 14, 2026

No description provided.

@genaris
ci: run tests on node 22 and 24 (drop 20)
b463887 
Signed-off-by: Ariel Gentile <gentilester@gmail.com>
@genaris genaris requested a review from a team as a code owner April 14, 2026 23:05
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 14, 2026 •
edited
Loading

⚠️ No Changeset found

Latest commit: e732037

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

hacdias
hacdias approved these changes Apr 15, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@hacdias hacdias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Someone needs to change the required tests on the Settings of the repository to match the new versions. I don't have permissions for that.

@berendsliedrecht
Copy link
Copy Markdown
Contributor

berendsliedrecht commented Apr 20, 2026

LGTM. Someone needs to change the required tests on the Settings of the repository to match the new versions. I don't have permissions for that.

Oh same... Maybe @ryjones could change this? We have some required tests which we removed, all the node 20 tests. And now we should require all node 24 tests.

@ryjones
Copy link
Copy Markdown
Member

ryjones commented Apr 20, 2026

OK, I've disabled node 20

@ryjones
Copy link
Copy Markdown
Member

ryjones commented Apr 20, 2026

24 is now required

@genaris genaris merged commit 7e78bcd into openwallet-foundation:main Apr 20, 2026
15 checks passed
@genaris genaris deleted the ci/test-on-24 branch April 20, 2026 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hacdias hacdias hacdias approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@genaris @berendsliedrecht @ryjones @hacdias