Report context cancelation as non-error - #13
Open
bboreham wants to merge 3 commits into
Open
Conversation
Someone else canceled this operation; we should not flag it as an error. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
Contributor
Author
|
I added some simple CircleCI config since it seems CircleCI removed the feature to have it work without. |
bboreham
marked this pull request as ready for review
October 28, 2021 15:57
Contributor
Author
|
@austinlparker Would you have time to review this? |
Contributor
Author
|
@austinlparker sorry to bug you personally, but you were the last person to merge anything in this repo. Would you be interested in handing over to someone else? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Someone else canceled this operation; we should not flag it as an error.
Example of a span flagged as an error when the operation was cancelled as un-needed:
This is a little bit similar to #1, but for the case that the Go context was canceled, rather than the gRPC operation.