-
Notifications
You must be signed in to change notification settings - Fork 27
SRVKP-10006: reverting 69bac9b to remove pipelines in console-extension.json #853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
SRVKP-10006: reverting 69bac9b to remove pipelines in console-extension.json #853
Conversation
|
@anwesha-palit-redhat: This pull request references SRVKP-10006 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
60dc45e to
9988819
Compare
lokanandaprabhu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anwesha-palit-redhat, lokanandaprabhu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@anwesha-palit-redhat: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Description
Removes navigation entry added during static plugin deprecation that's causing duplicate Pipelines entry in the OCP side navigation bar.
Problem
As part of the static plugin deprecation work, a new
console.navigation/hrefextension was added to replace the static plugin's navigation entry. However, this created a duplicate Pipelines entry in the OpenShift Console side navigation as OCP 4.21 is yet unreleased ( when console-plugin is enabled ).The added configuration included:
pipelines/pipelinesin admin perspectiveSolution
Removes the cherry-picked navigation entry configuration to eliminate the duplication.
Testing
Additional Notes
This reverts part of the static plugin deprecation migration. Post OCP 4.21 release this needs to be added back again