Support scientific notation representation in PPL#2827
Open
LantaoJin wants to merge 6 commits intoopensearch-project:mainfrom
Open
Support scientific notation representation in PPL#2827LantaoJin wants to merge 6 commits intoopensearch-project:mainfrom
LantaoJin wants to merge 6 commits intoopensearch-project:mainfrom
Conversation
Signed-off-by: Lantao Jin <ltjin@amazon.com>
dai-chen
previously approved these changes
Jul 16, 2024
Collaborator
dai-chen
left a comment
There was a problem hiding this comment.
Thanks for the changes!
Member
Author
Contributor
|
This PR is stalled because it has been open for 30 days with no activity. |
YANG-DB
previously approved these changes
Dec 30, 2024
YANG-DB
previously approved these changes
Dec 31, 2024
Contributor
|
This PR is stalled because it has been open for 30 days with no activity. |
Collaborator
|
Hi @LantaoJin, just wanna check if this is still on track or we can close it? |
Signed-off-by: Lantao Jin <ltjin@amazon.com>
Collaborator
|
@LantaoJin is this still being worked on? I see merge conflicts have been here for a while, overall lgtm if merge conflicts are resolved |
Contributor
|
This PR is stalled because it has been open for 2 weeks with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Numbers of scientific notation can be recognized in SQL, but not in PPL. With this PR, numbers of scientific notation can be identified as
doublein PPL as same as in SQL.Here are valid examples of scientific notation representations:
9e1,+9e+1,900e-1,9.0e1,9.0e+1,9.0E1,.9e+2,0.09e+3,900.0e-1,-900.0E-1.Verified the feature works both in v2 and v3.
Issues Resolved
Resolves #2826
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.