Update to yarn equivalent for linting#11531
Open
epugh wants to merge 2 commits intoopensearch-project:mainfrom
Open
Update to yarn equivalent for linting#11531epugh wants to merge 2 commits intoopensearch-project:mainfrom
epugh wants to merge 2 commits intoopensearch-project:mainfrom
Conversation
Signed-off-by: Eric Pugh <epugh@opensourceconnections.com>
epugh
requested review from
AMoo-Miki,
BionIT,
Flyingliuhub,
LDrago27,
Maosaic,
SuZhou-Joe,
ZilongX,
abbyhu2000,
ananzh,
angle943,
ashwin-pc,
bandinib-amzn,
curq,
d-buckner,
huyaboo,
joshuali925,
joshuarrrr,
kavilla,
manasvinibs,
mengweieric,
raintygao,
ruanyl,
sejli,
virajsanghvi,
wanglam,
xinruiba,
zengyan-amazon,
zhongnansu and
zhyuanqi
as code owners
epugh
requested review from
TackAdam,
paulstn,
ps48,
ruchidh and
sumukhswamy
as code owners
Contributor
❌ Changelog Entry Missing HyphenChangelog entries must begin with a hyphen (-). |
Contributor
PR Reviewer Guide 🔍(Review updated until commit 61de8ca)Here are some key observations to aid the review process:
|
7 tasks
Contributor
❌ Changelog Entry Missing HyphenChangelog entries must begin with a hyphen (-). |
Signed-off-by: Eric Pugh <epugh@opensourceconnections.com>
Contributor
|
Persistent review updated to latest commit 61de8ca |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11531 +/- ##
==========================================
+ Coverage 61.01% 61.47% +0.46%
==========================================
Files 4990 4988 -2
Lines 137539 136533 -1006
Branches 24104 23602 -502
==========================================
+ Hits 83916 83934 +18
+ Misses 47564 46567 -997
+ Partials 6059 6032 -27
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update Developer Guide for how to lint code using yarn.
Issues Resolved
n/a
Screenshot
Testing the changes
Run the suggested command! I scanned the rest of the DEVELOPER_GUIDE.md and didn't see any other uses of
nodethat should be converted toyarn.Changelog
doc: Update lint instructions to use yarn
Check List
yarn test:jestyarn test:jest_integration