-
Notifications
You must be signed in to change notification settings - Fork 110
export target osg-qt::osgQOpenGL to cmake #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
OTOH the project has no activity in three years, and it is still using Qt5. |
…correctly set; Qt5 and OSG are now correctly searched for if needed; link libraries and include path are now set transitively based on current system's OSG libraries, improving portability of install.
Export Target fixes for better transitive properties
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not use REQUIRED with find_dependency. (You loose key benefits vs. find_package.)
Co-authored-by: Kai Pastor <[email protected]>
Co-authored-by: Kai Pastor <[email protected]>
I wrote that in and was following the example from e.g. libpng (uses it for ZLIB), WebP (uses it for Threads), and vxgXchange (used for vsg). That said, I think I agree and am happy with the update, thanks for the suggestion. I agree also about the aliases. One is sufficient and it should match.
I've been using the older osgQt which feels like a different library than what's there now. The newest library looks like a rewrite that works but is less configurable and more tightly coupled. I'm working on patches for that locally and expect to be also looking at the Qt6 upgrade in the issues. I could create PRs to improve but am concerned no one is around to accept/reject. |
microsoft/vcpkg#44441
#53
#57
microsoft/vcpkg#26312
so many want to use osg-qt in the cmake way,
so may be we should export target osg-qt::osgQOpenGL to cmake