-
Notifications
You must be signed in to change notification settings - Fork 427
Rename variables if the name matches class name #5454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
timtebeek
merged 13 commits into
openrewrite:main
from
radoslaw-panuszewski:rename-variables-when-changing-type
May 31, 2025
+125
−2
Merged
Changes from 4 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
8551095
Rename variables if the name matches class name
radoslaw-panuszewski 8e132e2
Prevent variable name conflicts; support unicode characters
radoslaw-panuszewski 0820d5c
Fix tests in rewrite-kotlin
radoslaw-panuszewski f2f61a6
Add test verifying that random variables with matching name are not r…
radoslaw-panuszewski 5bad96a
Use 𐐅/𐐭 instead of Ą/ą in test since Ą is in BMP
radoslaw-panuszewski 9c4ea8f
Revert unicode characters handling in decapitalize method as it seems…
radoslaw-panuszewski 255bbb3
Follow naming convention for ctx
timtebeek 364f961
Move all logic into `visitVariable` and leverage `RenameVariable`
timtebeek 9ffa9cf
Swap order of checks
timtebeek 2eb0536
No changes to variable name without change to type
timtebeek 263f59c
Merge branch 'main' into rename-variables-when-changing-type
timtebeek 1381045
Update cursor before `generateVariableName` to avoid conflicts
timtebeek cc64311
Do not expect Kotlin changes just yet
timtebeek File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat idea indeed to rename these as well!