-
Notifications
You must be signed in to change notification settings - Fork 424
Move file to another directory #5373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…all files are moved)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
I spy *nix specific paths which would also make these tests fail when executed on a Windows machine or when using Windows based paths. |
@shanman190 I did write some behaviour to how I hope it is working plus the tests, but need to check :) |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@Jenson3210 , is the plan to only support *nix style paths for the |
@shanman190 yes indeed. As the SourcePath is always relative (still have to check if this is the case with Tim) to the repo root, I was thinking to have 1 uniform syntax for moveTo math (absolute inside repo root or relative to the current file/folder) Otherwise our recipes using this one always have to call it with a syntax for Windows and one for Unix, resulting in 2 recipes in the recipe list or complexer custom recipes. |
Or you choose to accept either and normalize the input within the recipe to allow the user to specify either, but handle it internally in a uniform way. This is what is done internally within |
Adapted the recipe to allow for window paths also in the moveTo option (and folder option) |
What's changed?
Added a recipe that moves files to another directory (resulting in renamed directories if all files are moved)
What's your motivation?
As there could be many use cases to in bulk rename directories, move files...
Anyone you would like to review specifically?
@timtebeek
Any additional context
Requested in slack
Checklist