Skip to content

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Dec 19, 2025

A required test fix after backport of JDK-8327114.


Progress

  • JDK-8341246 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Integration blocker

 ⚠️ Dependency #2523 must be integrated first

Issue

  • JDK-8341246: Test com/sun/tools/attach/PermissionTest.java fails access denied after JDK-8327114 (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2530/head:pull/2530
$ git checkout pull/2530

Update a local copy of the PR:
$ git checkout pull/2530
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2530/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2530

View PR using the GUI difftool:
$ git pr show -t 2530

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2530.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 19, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into pr/2523 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 19, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title backport 76283dd2701ca4ad5c1c99a66f3e8e3d0fe55d44 8341246: Test com/sun/tools/attach/PermissionTest.java fails access denied after JDK-8327114 Dec 19, 2025
@openjdk
Copy link

openjdk bot commented Dec 19, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Dec 19, 2025
@mlbridge
Copy link

mlbridge bot commented Dec 19, 2025

Webrevs

@GoeLin GoeLin force-pushed the goetz_backport_8341246 branch from d3befbc to 9cf72e4 Compare December 19, 2025 08:05
@openjdk
Copy link

openjdk bot commented Dec 19, 2025

@GoeLin Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@openjdk openjdk bot added clean Identical backport; no merge resolution required approval Requires approval; will be removed when approval is received and removed approval Requires approval; will be removed when approval is received labels Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant