Skip to content

Conversation

@mrserb
Copy link
Member

@mrserb mrserb commented Dec 24, 2025

The copyright year in "java.net.http" files updated in 2025 has been bumped to 2025. All files are updated which touched the src/java.net.http and related files.

The next command can be run (on top of this PR) to verify that each file had prior commits in 2025:

git diff HEAD~1 --name-only | while read f; do git log HEAD~1 --since="2025-01-01" --oneline -- "$f" | head -1 | grep -q . || echo "NOT IN 2025: $f"; done


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8374320: Update copyright year to 2025 for java.net.http in files where it was missed (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28973/head:pull/28973
$ git checkout pull/28973

Update a local copy of the PR:
$ git checkout pull/28973
$ git pull https://git.openjdk.org/jdk.git pull/28973/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28973

View PR using the GUI difftool:
$ git pr show -t 28973

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28973.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 24, 2025

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 24, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Dec 24, 2025

@mrserb The following labels will be automatically applied to this pull request:

  • core-libs
  • net
  • nio
  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@mrserb mrserb marked this pull request as ready for review December 24, 2025 02:52
@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 24, 2025
@mlbridge
Copy link

mlbridge bot commented Dec 24, 2025

Webrevs

@AlanBateman
Copy link
Contributor

I checked the http3 branch in the sandbox and several of these files had their last change in 2024, not 2025. When JEP 517 integrated then it might appear that they were created in 2025 even though they have exited in the http3 branch for longer than that.

@mrserb
Copy link
Member Author

mrserb commented Dec 24, 2025

I checked the http3 branch in the sandbox and several of these files had their last change in 2024, not 2025. When JEP 517 integrated then it might appear that they were created in 2025 even though they have exited in the http3 branch for longer than that.

correct, they appeared in jdk/master in 2025 as new files as part of the JEP integration. Not sure whether they should be excluded or not, since they were touched this year in some way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants