Skip to content

Conversation

@naotoj
Copy link
Member

@naotoj naotoj commented Dec 23, 2025

Removing the test from AOT Problem List. The test java/lang/IO/IO.java had a dependency on jdk.internal.le module, but it was removed in JDK26(https://bugs.openjdk.org/browse/JDK-8361613). Apart from that, the test case itself has been modified to not emit AOT/CDS logging messages in order for the output comparing test to succeed.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8374217: Remove IO.java test from AOT ProblemList (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28967/head:pull/28967
$ git checkout pull/28967

Update a local copy of the PR:
$ git checkout pull/28967
$ git pull https://git.openjdk.org/jdk.git pull/28967/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28967

View PR using the GUI difftool:
$ git pr show -t 28967

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28967.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 23, 2025

👋 Welcome back naoto! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 23, 2025

@naotoj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8374217: Remove IO.java test from AOT ProblemList

Reviewed-by: iklam

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Dec 23, 2025

@naotoj The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 23, 2025
@naotoj
Copy link
Member Author

naotoj commented Dec 23, 2025

/label add hotspot-runtime

@mlbridge
Copy link

mlbridge bot commented Dec 23, 2025

Webrevs

@openjdk
Copy link

openjdk bot commented Dec 23, 2025

@naotoj
The hotspot-runtime label was successfully added.

Copy link
Member

@iklam iklam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 23, 2025
/*
* @test
* @bug 8305457 8342936 8351435 8344706 8361613
* @bug 8305457 8342936 8351435 8344706 8361613 8374217
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Naoto, the changes look OK to me. However, the guidelines of using @bug for tests https://openjdk.org/guide/#jtreg say:

These bug ids refer to product bugs for which a fix is verified by this test. JBS issues that track changes to the test itself are not listed here.

So I think we shouldn't add this bug id here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs [email protected] hotspot-runtime [email protected] ready Pull request is ready to be integrated rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

3 participants