-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8374217: Remove IO.java test from AOT ProblemList #28967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
8374217: Remove IO.java test from AOT ProblemList #28967
Conversation
|
👋 Welcome back naoto! A progress list of the required criteria for merging this PR into |
|
@naotoj This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 7 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
/label add hotspot-runtime |
|
@naotoj |
iklam
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
| /* | ||
| * @test | ||
| * @bug 8305457 8342936 8351435 8344706 8361613 | ||
| * @bug 8305457 8342936 8351435 8344706 8361613 8374217 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello Naoto, the changes look OK to me. However, the guidelines of using @bug for tests https://openjdk.org/guide/#jtreg say:
These bug ids refer to product bugs for which a fix is verified by this test. JBS issues that track changes to the test itself are not listed here.
So I think we shouldn't add this bug id here.
Removing the test from AOT Problem List. The test
java/lang/IO/IO.javahad a dependency onjdk.internal.lemodule, but it was removed in JDK26(https://bugs.openjdk.org/browse/JDK-8361613). Apart from that, the test case itself has been modified to not emit AOT/CDS logging messages in order for the output comparing test to succeed.Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28967/head:pull/28967$ git checkout pull/28967Update a local copy of the PR:
$ git checkout pull/28967$ git pull https://git.openjdk.org/jdk.git pull/28967/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28967View PR using the GUI difftool:
$ git pr show -t 28967Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28967.diff
Using Webrev
Link to Webrev Comment