Skip to content

8358813: remove more bindings for JPasswordFields in Aqua #25688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mickleness
Copy link
Contributor

@mickleness mickleness commented Jun 9, 2025

There were a few action bindings available in JPasswordFields in Aqua that let you identify the boundaries of words.

This came to my attention while looking at the related work #25443 . In that PR we said we should iterate across all available L&Fs, so this PR copies that same approach. (The original complaint only focused on Aqua, though.)


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Integration blocker

 ⚠️ Failed to retrieve information on issue 8358813. Please make sure it exists and is accessible.

Warning

 ⚠️ Found leading lowercase letter in issue title for 8358813: remove more bindings for JPasswordFields in Aqua

Issue

  • ⚠️ Failed to retrieve information on issue 8358813.

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25688/head:pull/25688
$ git checkout pull/25688

Update a local copy of the PR:
$ git checkout pull/25688
$ git pull https://git.openjdk.org/jdk.git pull/25688/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25688

View PR using the GUI difftool:
$ git pr show -t 25688

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25688.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 9, 2025

👋 Welcome back mickleness! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 9, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Jun 9, 2025

@mickleness The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mickleness
Copy link
Contributor Author

IMO this PR is a simple response that interfaces with an existing method. I recommend this approach because it should be relatively low-risk, and it is based on existing precedent.

By contrast: #25443 does something more aggressive (and interesting). It replaces selectWordAction with selectLineAction. That looks (to me) like a more thorough/better approach to the general problem of accidentally interacting with words in a password field. This PR should resolve any KeyStroke-based actions, but in JDK-8354646 the original complaint had to do with double-clicking the mouse; so this PR wouldn't impact those steps.

I haven't explored this thoroughly yet, but glancing through the AccessibleJTextField suggests an AX interface could still have access (via AccessibleActions) to the word-related actions we're trying to restrict access to. If so: this problem (accessing words in a password field) keeps popping up, and removing/replacing the unwanted actions seems like the most thorough response.

(Also see JDK-6191897 and JDK-4231444 ).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant