Skip to content

8355792: Remove expired flags in JDK 26 #25686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

dholmes-ora
Copy link
Member

@dholmes-ora dholmes-ora commented Jun 9, 2025

Please review these trivial start-of-release updates in relation to expired flags:

  • the flag table is updated to remove entries for expired flags (2 this time)
  • the Java man page "Removed options" section is updated (none are being removed (expired) in JDK 26)

Thanks


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8355792: Remove expired flags in JDK 26 (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25686/head:pull/25686
$ git checkout pull/25686

Update a local copy of the PR:
$ git checkout pull/25686
$ git pull https://git.openjdk.org/jdk.git pull/25686/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25686

View PR using the GUI difftool:
$ git pr show -t 25686

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25686.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 9, 2025

👋 Welcome back dholmes! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 9, 2025

@dholmes-ora This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8355792: Remove expired flags in JDK 26

Reviewed-by: coleenp, kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • d186dac: 8357591: Re-enable CDS test cases for jvmci after JDK-8345826

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 9, 2025
@openjdk
Copy link

openjdk bot commented Jun 9, 2025

@dholmes-ora The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented Jun 9, 2025

Webrevs

Copy link
Contributor

@coleenp coleenp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 9, 2025
@dholmes-ora
Copy link
Member Author

Thanks for the review @coleenp !

Copy link
Contributor

@vnkozlov vnkozlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good.

@dholmes-ora
Copy link
Member Author

Thanks for the review @vnkozlov !

/integrate

@openjdk
Copy link

openjdk bot commented Jun 9, 2025

@dholmes-ora Since your change was applied there have been 13 commits pushed to the master branch:

It was not possible to rebase your changes automatically. Please merge master into your branch and try again.

@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Jun 9, 2025
@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 9, 2025
@dholmes-ora
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 9, 2025

Going to push as commit bcf8607.
Since your change was applied there has been 1 commit pushed to the master branch:

  • d186dac: 8357591: Re-enable CDS test cases for jvmci after JDK-8345826

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 9, 2025
@openjdk openjdk bot closed this Jun 9, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 9, 2025
@openjdk
Copy link

openjdk bot commented Jun 9, 2025

@dholmes-ora Pushed as commit bcf8607.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dholmes-ora dholmes-ora deleted the 8355792-expired-flags branch June 10, 2025 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime [email protected] integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants