8358556: Assert when running with -XX:-UseLibmIntrinsic

[missa-prime]

This change fixes unwanted calls to the cbrt and tanh intrinsics on x86 when they are explicitly disabled by flags such as -XX:-UseLibmIntrinsic or -XX:-InlineIntrinsics.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8358556: Assert when running with -XX:-UseLibmIntrinsic (Bug - P4)

Reviewers

• Sandhya Viswanathan (@sviswa7 - Reviewer)
• Vladimir Kozlov (@vnkozlov - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25680/head:pull/25680
$ git checkout pull/25680

Update a local copy of the PR:
$ git checkout pull/25680
$ git pull https://git.openjdk.org/jdk.git pull/25680/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25680

View PR using the GUI difftool:
$ git pr show -t 25680

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25680.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back missa-prime! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@missa-prime This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8358556: Assert when running with -XX:-UseLibmIntrinsic

Reviewed-by: sviswanathan, kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 73 new commits pushed to the master branch:

• e9216ef: 8358734: Remove JavaTimeSupplementary resource bundles
• e5196fc: 8358764: (sc) SocketChannel.close when thread blocked in read causes connection to be reset (win)
• c98dffa: 8357982: Fix several failing BMI tests with -XX:+UseAPX
• ... and 70 more: https://git.openjdk.org/jdk/compare/3cf3e4bbec26a84d77cb7a3125a60ba1e1e4ee97...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@sviswa7, @vnkozlov) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@missa-prime The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[missa-prime]

@dholmes-ora Does this fix the -XX:-InlineIntrinsics assertion failures when running CubeRootTests.java and HyperbolicTests.java? I couldn't reproduce those, but I could reproduce the one with java -XX:-UseLibmIntrinsic -version.

[mlbridge]

Webrevs

• 05: Full - Incremental (fa21605f)
• 04: Full - Incremental (aff9ca09)
• 03: Full - Incremental (b887243c)
• 02: Full - Incremental (8dadb41c)
• 01: Full - Incremental (c11f54e1)
• 00: Full (21cda33d)

[dholmes-ora]

@dholmes-ora Does this fix the -XX:-InlineIntrinsics assertion failures when running CubeRootTests.java and HyperbolicTests.java? I couldn't reproduce those, but I could reproduce the one with java -XX:-UseLibmIntrinsic -version.

Yes it does - thanks. Though I'm still unclear why only a couple of these math intrinsics are affected by -XX:-InineIntrinsics ??

[missa-prime]

@dholmes-ora Does this fix the -XX:-InlineIntrinsics assertion failures when running CubeRootTests.java and HyperbolicTests.java? I couldn't reproduce those, but I could reproduce the one with java -XX:-UseLibmIntrinsic -version.

Yes it does - thanks. Though I'm still unclear why only a couple of these math intrinsics are affected by -XX:-InineIntrinsics ??

The unaffected math intrinsics (dsin, dcos, dexp, ...) can fall back to alternate C++ implementations in the shared runtime when the stubs aren't generated by -XX:-InlineIntrinsics or -XX:-UseLibmIntrinsic. This isn't the case for the dtanh and dcbrt intrinsics.

[sviswa7]

Looks good to me.

[missa-prime]

Looks good to me.

@sviswa7 I had to make some more changes to cover the linux-x64-hs-zero build.

[sviswa7]

Changes look good.

[vnkozlov]

Please, do not push until we review and test it.

[sviswa7]

Thanks @vnkozlov, we will look forward to your testing.

[vnkozlov]

I submitted testing.

[vnkozlov]

My testing passed

[missa-prime]

/integrate

[openjdk]

@missa-prime
Your change (at version fa21605) is now ready to be sponsored by a Committer.

[sviswa7]

/sponsor

[openjdk]

Going to push as commit ef4cbec.
Since your change was applied there have been 73 commits pushed to the master branch:

• e9216ef: 8358734: Remove JavaTimeSupplementary resource bundles
• e5196fc: 8358764: (sc) SocketChannel.close when thread blocked in read causes connection to be reset (win)
• c98dffa: 8357982: Fix several failing BMI tests with -XX:+UseAPX
• ... and 70 more: https://git.openjdk.org/jdk/compare/3cf3e4bbec26a84d77cb7a3125a60ba1e1e4ee97...master

Your commit was automatically rebased without conflicts.

[openjdk]

@sviswa7 @missa-prime Pushed as commit ef4cbec.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.