Skip to content

Conversation

@cdw200806
Copy link

@cdw200806 cdw200806 commented Apr 13, 2025

"In Red-Black Trees, a red node cannot have any red children; this rule is violated even if only one child is red, not just when both children are red."


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24612/head:pull/24612
$ git checkout pull/24612

Update a local copy of the PR:
$ git checkout pull/24612
$ git pull https://git.openjdk.org/jdk.git pull/24612/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24612

View PR using the GUI difftool:
$ git pr show -t 24612

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24612.diff

"In Red-Black Trees, a red node cannot have any red children; this rule is violated even if only one child is red, not just when both children are red."
@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Apr 13, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Apr 13, 2025

Hi @cdw200806, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user cdw200806" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@cdw200806
Copy link
Author

cdw200806 commented Apr 13, 2025 via email

@openjdk
Copy link

openjdk bot commented Apr 13, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Apr 13, 2025

@cdw200806 The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@cdw200806
Copy link
Author

cdw200806 commented Apr 13, 2025

/signed
I have signed oca. But maybe the reviewer has not handle it yet.

@bridgekeeper bridgekeeper bot added the oca-verify Needs verification of OCA signatory status label Apr 13, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Apr 13, 2025

Thank you! Please allow for up to two weeks to process your OCA, although it is usually done within one to two business days. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

@liach
Copy link
Member

liach commented Apr 13, 2025

Makes sense. Since this is assertion code, there is really no way to add a test...

@cdw200806
Copy link
Author

/signed

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 14, 2025

Already processed the signed command

@bridgekeeper
Copy link

bridgekeeper bot commented May 12, 2025

@cdw200806 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@cdw200806
Copy link
Author

cdw200806 commented May 12, 2025 via email

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 10, 2025

@cdw200806 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@cdw200806
Copy link
Author

cdw200806 commented Jun 10, 2025 via email

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 8, 2025

@cdw200806 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@cdw200806
Copy link
Author

cdw200806 commented Jul 8, 2025 via email

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 5, 2025

@cdw200806 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@cdw200806
Copy link
Author

cdw200806 commented Aug 5, 2025 via email

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 2, 2025

@cdw200806 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@cdw200806
Copy link
Author

cdw200806 commented Sep 2, 2025 via email

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 30, 2025

@cdw200806 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@cdw200806
Copy link
Author

cdw200806 commented Sep 30, 2025 via email

@bridgekeeper bridgekeeper bot removed oca Needs verification of OCA signatory status oca-verify Needs verification of OCA signatory status labels Oct 28, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 29, 2025

@cdw200806 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@cdw200806
Copy link
Author

cdw200806 commented Oct 29, 2025 via email

@cdw200806
Copy link
Author

/signed

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 30, 2025

You are already a known contributor!

@cdw200806
Copy link
Author

Makes sense. Since this is assertion code, there is really no way to add a test...

Hi, Chen Liang
After half year, finally I pass the oca process.
Do you know who can help me review this pr?
And, seems this pr need a ticket number before merge it. I don't know how to get it.
Contributing to JDK is a interesting thing. But If this pr not need merge, I can close it.

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 27, 2025

@cdw200806 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@cdw200806
Copy link
Author

cdw200806 commented Nov 27, 2025 via email

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 25, 2025

@cdw200806 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@cdw200806
Copy link
Author

cdw200806 commented Dec 25, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants