Dialect factory package #450
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move related classes into
dialect.factory
package. Associate type factories with their types and op factories with their ops. This motivates the creation of a sealedCoreType
interface (likely useful anyway).Progress
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/babylon.git pull/450/head:pull/450
$ git checkout pull/450
Update a local copy of the PR:
$ git checkout pull/450
$ git pull https://git.openjdk.org/babylon.git pull/450/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 450
View PR using the GUI difftool:
$ git pr show -t 450
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/babylon/pull/450.diff