Skip to content

Dialect factory package #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: code-reflection
Choose a base branch
from

Conversation

PaulSandoz
Copy link
Member

@PaulSandoz PaulSandoz commented Jun 18, 2025

Move related classes into dialect.factory package. Associate type factories with their types and op factories with their ops. This motivates the creation of a sealed CoreType interface (likely useful anyway).


Progress

  • Change must not contain extraneous whitespace

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/babylon.git pull/450/head:pull/450
$ git checkout pull/450

Update a local copy of the PR:
$ git checkout pull/450
$ git pull https://git.openjdk.org/babylon.git pull/450/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 450

View PR using the GUI difftool:
$ git pr show -t 450

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/babylon/pull/450.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 18, 2025

👋 Welcome back psandoz! A progress list of the required criteria for merging this PR into code-reflection will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 18, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant