Feat healthchecks #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces overcomplicated token persistence system with simple in-memory JWT caching, eliminating P0 encryption vulnerability. Removes 1,650+ lines of unused Amazon Ads provider/registry/token_store code that was copy-pasted from another project. Security hardening: - Token logging: Only log length, apply SanitizingFormatter globally - Auth fallback: Remove unsafe refresh token fallback, fail with actionable errors - Timeouts: Add timeout=(10,30) to all 16 HTTP requests (DoS protection) - SSRF: Validate pagination URLs stay on expected domain - LLM opt-in: Require OPENBRIDGE_ENABLE_LLM_VALIDATION=true (defaults false) Simplified auth stack (src/auth/simple.py): - ~220 lines vs original 2,000+ line system - In-memory JWT caching with 5-min buffer before expiry - No disk persistence, no encryption needed - Clean fail-closed design Documentation: - Add SECURITY.md with hardening details - Update README with new env vars (OPENBRIDGE_API_TIMEOUT, OPENBRIDGE_ENABLE_LLM_VALIDATION) - Update .env.example with proper OPENBRIDGE_* naming - Remove deprecated AMAZON_ADS_* references Tests: - Add tests/test_security_fixes.py with JWT caching, SSRF, timeout, and LLM opt-in coverage - Update legacy tests for stricter auth behavior - All 26 tests passing 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merges fixes and updates to clean-up the legacy code