fix(client): treat empty OPENAI_BASE_URL as unset, falling back to default endpoint#2997
Open
NIK-TIGER-BILL wants to merge 1 commit intoopenai:mainfrom
Open
fix(client): treat empty OPENAI_BASE_URL as unset, falling back to default endpoint#2997NIK-TIGER-BILL wants to merge 1 commit intoopenai:mainfrom
NIK-TIGER-BILL wants to merge 1 commit intoopenai:mainfrom
Conversation
…fault endpoint When OPENAI_BASE_URL is set to an empty string, os.environ.get() returns '' which is falsy but not None, causing the second None-check to be skipped. This means an empty string is passed as base_url, leading to confusing errors. Using ensures that both unset and empty string values are treated identically, falling back to the default https://api.openai.com/v1 endpoint. Closes openai#2927
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When
OPENAI_BASE_URLis set to an empty string (e.g.export OPENAI_BASE_URL=""),os.environ.get("OPENAI_BASE_URL")returns""which is notNone. This causes the secondif base_url is Nonecheck to be skipped, so the empty string is passed asbase_urlto the HTTP client, resulting in confusing connection errors rather than falling back to the default endpoint.Root Cause
Fix
This fix is applied to both
OpenAI(sync) andAsyncOpenAIclasses.Changes
src/openai/_client.py: Useor Noneto coerce empty string env var toNonein both sync and async client constructorsCloses #2927