Preserve byte-reader positions when replaying requests - #911
Open
sylvesterkaczmarek wants to merge 1 commit into
Open
Preserve byte-reader positions when replaying requests#911sylvesterkaczmarek wants to merge 1 commit into
sylvesterkaczmarek wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix a request-body replay bug found while checking the current SDK. A positioned
*bytes.Readeris rewound before its first request, even thoughContentLengthdescribes only the remaining bytes. EveryGetBody()call also returns the same reader, so reading one replay changes other replays and the original request.Snapshot the initial reader position and give each replay an independent cursor. The first request still consumes the supplied reader; no payload copy, public API, dependency, or retry-policy change is needed.
Regression coverage
Public-client tests use a real loopback HTTP server to verify partially consumed and exhausted readers through a retry, plus interleaved replay readers opened by middleware. All three cases fail on the unmodified base and pass with the fix.
Validation
SKIP_MOCK_TESTS=true go test -race . ./internal/requestconfig: 753 passing test/subtest records, 247 mock-dependent skips.go vet ./..., all six./scripts/lintpasses, andgit diff --checkpass.-race ./...run encounters existing X.509 test failures on Go 1.27.1. The same failures reproduce in a clean checkout of basea57d34c; no clean full-suite result is claimed.