ci: resolve fork PRs missing Castiron run associations - #910
ci: resolve fork PRs missing Castiron run associations#910marcuswood-oai wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Castiron custom code✅ No new custom-code files detected. 16 mixed files remain; 2 existing customizations changed. Compared
14 existing customizations unchanged
A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 34418261527 --repo openai/openai-go \
--name castiron-custom-code-34418261527-1 --dir /tmp/castiron-custom-code-34418261527-1
git apply --stat /tmp/castiron-custom-code-34418261527-1/custom-code.patch
cat /tmp/castiron-custom-code-34418261527-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin a57d34cb7c5839cfd5790d3d77d9c579c837b192 6843aeb0b9760b707e9b45057f435523a34a063c
python3 scripts/castiron/custom_code_report.py report \
--base a57d34cb7c5839cfd5790d3d77d9c579c837b192 \
--head 6843aeb0b9760b707e9b45057f435523a34a063c --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-6843aeb0b976
cat /tmp/castiron-custom-code-6843aeb0b976/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
Summary
When GitHub omits a fork PR from both the workflow-run association and the base repository's commit-to-PR endpoint, Castiron cannot resolve the PR and leaves the required budget statuses missing.
Port the focused fix from openai/openai-python#3831: fall back to listing open PRs by the source run's fork owner and branch, then retain the existing exact-head, target, freshness, and ambiguity checks. Cover report computation, budget evaluation, and publication; update the reporter integrity digest.
Validation
scripts/castiron;git diff --check.The trusted handler runs from main. After merging, rerun affected Castiron custom-code workflows so the required statuses can be published.
SDK CODEOWNER review is required. The repository-requested Codex Security diff scan remains outstanding because the plugin is not installed in this session.