fix(ssestream): synchronize decoder registry - #887
Open
sylvesterkaczmarek wants to merge 1 commit into
Open
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make the public SSE decoder registry safe for concurrent registration and stream creation.
RegisterDecoderwrites the package-level registry whileNewDecoderreads it. A focused race test on currentmainreports a data race and can terminate withfatal error: concurrent map writes.This change protects registry access with an
RWMutex. Decoder lookup copies the factory while holding the read lock, then releases the lock before invoking it.Fixes #886.
Testing
go test -racereproduction: data race plusfatal error: concurrent map writesgo test -race ./packages/ssestream -count=1: passed on Go 1.26.7SKIP_MOCK_TESTS=true go test ./...: passed on Go 1.26.7./scripts/check-go-mod: all four modules tidy./scripts/lint: all analyzer passes reported 0 issuesgit diff --check: passedNo decoder-selection semantics or public API signatures change.