Fix Windows checkout by removing unused trailing-space directory - #3064
Open
vegerot wants to merge 1 commit into
Open
Fix Windows checkout by removing unused trailing-space directory#3064vegerot wants to merge 1 commit into
vegerot wants to merge 1 commit into
Conversation
Contributor
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the unused
examples/data/hotel_invoices/extracted_invoice_json /directory, whose name ends with a space. This restores native Windows checkout.The 31 files in
examples/data/hotel_invoices/extracted_invoice_json/remain unchanged.Motivation
A fresh Windows clone downloads the repository but fails during checkout with
error: invalid pathfor the trailing-space directory.Both directories were introduced in #1273. They contain the same 31 filenames, but different generated extraction results. The notebook
examples/Data_extraction_transformation.ipynbreads and writes only the directory without the space. No tracked source references the trailing-space directory.This removes the unused output set and preserves the dataset referenced by the notebook.
Validation
core.protectNTFS=true, all 3,133 tracked files, and clean status.git diff --checkpasses.uv run --no-project --with nbformat python .github/scripts/check_notebooks.pypasses: no changed notebooks.Checklist
Related work
This overlaps with existing fixes in #2468, #2495, #2739, and #2794. In particular, #2794 removes the same unused directory. This PR adds verification from a fresh Windows checkout of the current base.