Skip to content

Fix Windows checkout by removing unused trailing-space directory - #3064

Open
vegerot wants to merge 1 commit into
openai:mainfrom
vegerot:fix/windows-invoice-directory
Open

Fix Windows checkout by removing unused trailing-space directory#3064
vegerot wants to merge 1 commit into
openai:mainfrom
vegerot:fix/windows-invoice-directory

Conversation

@vegerot

@vegerot vegerot commented Sep 8, 2026

Copy link
Copy Markdown

Summary

Remove the unused examples/data/hotel_invoices/extracted_invoice_json / directory, whose name ends with a space. This restores native Windows checkout.

The 31 files in examples/data/hotel_invoices/extracted_invoice_json/ remain unchanged.

Motivation

A fresh Windows clone downloads the repository but fails during checkout with error: invalid path for the trailing-space directory.

Both directories were introduced in #1273. They contain the same 31 filenames, but different generated extraction results. The notebook examples/Data_extraction_transformation.ipynb reads and writes only the directory without the space. No tracked source references the trailing-space directory.

This removes the unused output set and preserves the dataset referenced by the notebook.

Validation

  • A fresh local Windows clone of this commit succeeds with core.protectNTFS=true, all 3,133 tracked files, and clean status.
  • All 31 retained invoice files parse as JSON and remain unchanged.
  • The diff contains exactly 31 deletions under the trailing-space directory.
  • Remaining tracked paths have no trailing spaces, trailing periods, or case collisions.
  • git diff --check passes.
  • uv run --no-project --with nbformat python .github/scripts/check_notebooks.py passes: no changed notebooks.

Checklist

  • Self-review completed.
  • Registry and authors reviewed: no new cookbook content or metadata changes are needed.
  • No Markdown or notebook changes; the docs-editor check does not apply.

Related work

This overlaps with existing fixes in #2468, #2495, #2739, and #2794. In particular, #2794 removes the same unused directory. This PR adds verification from a fresh Windows checkout of the current base.

@vegerot
vegerot requested a review from a team as a code owner September 8, 2026 03:52
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-08T03:55:26.726398Z e040607 PR opened
🔒 Security Review Completed 2026-09-08T03:59:05.855126Z e040607 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant