Add back error messages #5528
Add back error messages #5528
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| fn build_denial_reason_from_output(output: &ExecToolCallOutput) -> String { | ||
| format!("command failed: {}\nretry without sandbox?", output.aggregated_output.text) |
There was a problem hiding this comment.
The retry prompt now formats command failed: {output}\nretry without sandbox?, which includes the full aggregated command output. The existing approval tests (core/tests/suite/approvals.rs) assert the reason is the constant "command failed; retry without sandbox?", so this change will immediately break those scenarios and reintroduces OS‑specific and potentially multiline text into the approval reason. Either trim/normalize the message or update the tests and callers that expect the concise string.
Useful? React with 👍 / 👎.
1 participant
No description provided.