refactor: share Codex session execution - #917
Conversation
|
@codex review Please review exact head |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
Standard scans and Deep workers duplicate Codex construction and streamed-turn handling. Share that small execution leaf while retaining each caller's permissions, failure handling, artifact acceptance and follow-up behavior.
Changes
Testing
2135d4c3: Ruff lint and format, SDKbuild:ci, source compatibility check and its nine tests.2135d4c3. All 495 package payload files match the parent after the build-resolution fix.Risk and rollout
The shared module is internal and bundled into the existing outputs. Public commands, options, defaults and result fields are unchanged. Standard retains its writable permissions; Deep retains read-only source access, explicit denials, disabled network access and bound artifact tools. Existing callers continue to own cancellation, retry and result acceptance.
This focused change has no state migration or scheduler change. Review the provider-forwarding and missing-usage corrections separately from the mechanical extraction. Installed Linux checks do not establish native Windows or macOS behavior; their CI results remain required. This draft is not ready to merge.
Public disclosure review