Conversation
franzpoeschel
force-pushed
the
synchronous-flush
branch
from
53bdf60 to
9c02a26
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| std::vector<double> res(udims.size() * 7); | ||
| // for (size_t i = 0; i < udims.size(); ++i) | ||
| // { | ||
| // res[7 * i] = 1; |
Check notice
Code scanning / CodeQL
Commented-out code Note
| auto init_directly = [this, &comm..., &filepath]( | ||
| std::unique_ptr<ParsedInput> parsed_input, | ||
| json::TracingJSON tracing_json) { | ||
| json::TracingJSON tracing_json, |
Check notice
Code scanning / CodeQL
Large object passed by value Note
| // TODO: unitSI | ||
| // REQUIRE(r["x"].numAttributes() == 0); | ||
| // REQUIRE(r["y"].numAttributes() == 0); | ||
| // REQUIRE(r["z"].numAttributes() == 0); |
Check notice
Code scanning / CodeQL
Commented-out code Note test
| else | ||
| { | ||
| auto read_again = E_x_read.loadChunk<int>({0, 0}, {mpi_size, 4}); | ||
| // REQUIRE_THROWS(read.flush()); |
Check notice
Code scanning / CodeQL
Commented-out code Note test
franzpoeschel
force-pushed
the
synchronous-flush
branch
2 times, most recently
from
3b5c07f to
c725c7b
Compare
Moved to finalize(), degraded to warning
prep for reading
bit of code duplication, but better than CRT complexity
for more information, see https://pre-commit.ci
franzpoeschel
force-pushed
the
synchronous-flush
branch
from
84d0f30 to
6e9c239
Compare
| std::move(ls_cfg), | ||
| /*flush_immediately=*/false); | ||
| } | ||
| // storeChunk(std::move(data), std::move(o), std::move(e)); |
Check notice
Code scanning / CodeQL
Commented-out code Note
| { | ||
| template <typename T, typename RecordType> | ||
| PostProcessConvertedAttributeImpl<T, RecordType>:: | ||
| PostProcessConvertedAttributeImpl(RecordType record_in, handler_t reader_in) |
Check notice
Code scanning / CodeQL
Large object passed by value Note
franzpoeschel
force-pushed
the
synchronous-flush
branch
from
af38436 to
822c03f
Compare
for more information, see https://pre-commit.ci
1 participant
Flush immediately upon
storeChunk()/loadChunk(), no flushing neededTODO: