Skip to content

Conversation

@JaySoni1
Copy link
Contributor

@JaySoni1 JaySoni1 commented Dec 28, 2025

Changes Made:

-Fixed date/time rendering issue in "Manage Scheduler and COB Jobs" page (Previous Run and Next Run columns) and Data Tables (Created At and Updated At fields) where dates were displaying incorrectly with day-of-week abbreviations (e.g., "2025-12-SaT11:13:20-06:00" instead of "2025-12-28T11:13:20-06:00") by correcting the Moment.js format string in the [datetimeFormat] pipe from 'yyyy-MM-ddTHH:mm:ssZ' to 'YYYY-MM-DDTHH:mm:ssZ'.

WEB-527

Before :-
image

image

After :-
image

image

… Scheduler and COB Jobs and Data table pages
@coderabbitai
Copy link

coderabbitai bot commented Dec 28, 2025

Note

.coderabbit.yaml has unrecognized properties

CodeRabbit is using all valid settings from your configuration. Unrecognized properties (listed below) have been ignored and may indicate typos or deprecated fields that can be removed.

⚠️ Parsing warnings (1)
Validation error: Unrecognized key(s) in object: 'pre_merge_checks'
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Walkthrough

Updated the default date format token in DatetimeFormatPipe from lowercase yyyy to uppercase YYYY. This modifies the date formatting behavior when no custom format is provided, changing the ISO-like year representation in the output string.

Changes

Cohort / File(s) Summary
Date Format Token Update
src/app/pipes/datetime-format.pipe.ts
Changed default date format token from yyyy to YYYY in the pipe's date formatting logic

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • steinwinde
  • IOhacker
  • alberto-art3ch

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly addresses the main change: fixing date/time format rendering issues in specific UI components by correcting the Moment.js format string in the DatetimeFormatPipe.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3de48bc and 78d9342.

📒 Files selected for processing (1)
  • src/app/pipes/datetime-format.pipe.ts
🧰 Additional context used
📓 Path-based instructions (1)
src/app/**

⚙️ CodeRabbit configuration file

src/app/**: For Angular code: verify component separation, trackBy on *ngFor,
strict type safety, and clean observable patterns.

Files:

  • src/app/pipes/datetime-format.pipe.ts
🔇 Additional comments (2)
src/app/pipes/datetime-format.pipe.ts (2)

29-29: LGTM! Correct Moment.js format tokens.

The change from lowercase yyyy to uppercase YYYY is correct. Moment.js uses case-sensitive format tokens where YYYY represents a 4-digit year, while lowercase yyyy is not a valid Moment.js token and was causing the incorrect rendering mentioned in the PR description.


2-2: Moment.js version 2.29.4 is already patched for known vulnerabilities (CVE-2022-31129 and CVE-2022-24785). This version includes the security fixes and does not require verification or update for these issues. The caret specifier (^2.29.4) already allows updates to 2.30.1 if needed. Consider that Moment.js is in maintenance mode; for future refactoring, evaluate whether a modern date library would be appropriate for the project.

Likely an incorrect or invalid review comment.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@IOhacker IOhacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IOhacker IOhacker merged commit 26c89cf into openMF:dev Dec 28, 2025
4 checks passed
@JaySoni1
Copy link
Contributor Author

@IOhacker Thank You for review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants