feat(activate): Phase C Wave 1 — end-to-end Store5 migration

[therajanmaurya]

Summary

Phase C Wave 1 — first end-to-end feature migration. Establishes the migration template that Waves 2-7 replicate by touching all five layers of the architecture per the revised plan: core/network → core/database → core/data → core/domain (delete pure delegators) → feature/* ({ui, di, navigation}/ restructure).

Activate is the smallest mutation feature (3 isolated submit endpoints: client / center / group). Picking it first proves the pattern without offline-draft complexity.

Architectural deliverables (seeded for all future waves)

core/data + core/ui re-export layers

• core/data/build.gradle.kts: api(projects.coreBase.store) → api(projects.core.store) (route through the seam)
• core/data/.../store/SubmitTypes.kt: typealias SubmitHandler<R> / SubmitState<R> + CoroutineScope.submitHandler<R>() extension
• core/ui/build.gradle.kts: + api(projects.coreBase.ui)
• core/ui/.../store/ViewModelTypes.kt: typealias BaseViewModel<S, E, A>

Feature modules import com.mifos.core.data.store.* and com.mifos.core.ui.store.* and never touch template.core.base.store.* directly in their gradle. Composables (SubmitProgressOverlay, SubmitResultHandler, LocalScreenStateDefaults) can't be typealias-ed in Kotlin — they're imported by name via the api chain (feature → core/ui → core-base/ui).

core/network per-resource API rewrite

NEW per-resource subpackages following kmp-project-template/core/network/<feature>/{api,dto}/:

• core/network/client/api/ClientApi.kt — suspend activate() returns PostClientsClientIdResponse
• core/network/center/api/CenterApi.kt — suspend activate() returns PostCentersCenterIdResponse
• core/network/group/api/GroupApi.kt — suspend activate() returns HttpResponse (Fineract returns no typed body)

Each interface is per-resource (not per-action); future client/center/group feature waves add more methods to the same files.

core/network/di/NetworkModule.kt: 3 new single { get<Ktorfit>().createXxxApi() } factories.

Method-level @Deprecated annotations on legacy DataManagerClient.activateClient, DataManagerCenter.activateCenter, DataManagerGroups.activateGroup, ClientService.activateClient, CenterService.activateCenter, GroupService.activateGroup — those classes have many other live methods, so file-level deprecation isn't appropriate.

core/data/activate/ (relocate + rewrite)

git mv relocates:

• core/data/repository/ActivateRepository.kt → core/data/activate/ActivateRepository.kt
• core/data/repositoryImp/ActivateRepositoryImp.kt → core/data/activate/impl/ActivateRepositoryImpl.kt

ActivateRepository interface simplified: drops nullable ActivatePayload?; activateGroup() no longer returns HttpResponse — repository throws on non-2xx.

ActivateRepositoryImpl now injects (ClientApi, CenterApi, GroupApi) — no DataManager dependency.

core/data/.../di/RepositoryModule.kt: import update + singleOf(::ActivateRepositoryImpl) bind ActivateRepository::class. Repository binding lives in core/data per the Koin DI ownership boundary in C-features.md.

core/domain — delete 3 pure-delegator use cases

• ActivateClientUseCase.kt (deleted)
• ActivateCenterUseCase.kt (deleted)
• ActivateGroupUseCase.kt (deleted)
• UseCaseModule.kt: 3 factoryOf(::ActivateXxxUseCase) entries + their imports removed

feature/activate/{ui, di, navigation}/ restructure

Was flat (ActivateViewModel.kt, ActivateScreen.kt, ActivateUiState.kt, ActivateNavigation.kt all at root). Now:

feature/activate/.../
├── ui/
│   ├── ActivateState.kt        — MVI state with TargetType enum + success/failure StringResource lookups
│   ├── ActivateAction.kt       — sealed interface ActivateClient / ActivateCenter / ActivateGroup
│   ├── ActivateViewModel.kt    — extends BaseViewModel<State, Nothing, Action>
│   └── ActivateScreen.kt       — uses SubmitProgressOverlay + SubmitResultHandler; includes @Preview
├── di/
│   └── ActivateModule.kt       — viewModelOf(::ActivateViewModel)  (no Repository binding)
└── navigation/
    ├── ActivateRoute.kt        — @Serializable data class (split from Navigation)
    └── ActivateNavigation.kt   — NavGraphBuilder.activateDestination + NavController.navigateToActivateRoute

VM no longer collects Flow<DataState>. SubmitHandler<Unit> drives the Submitting → Submitted | Failed lifecycle. Screen-side terminal effects via SubmitResultHandler; Submitting overlay via SubmitProgressOverlay. Submit button enabled = !isSubmitting (framework also dedupes double-tap).

@Preview restored using org.jetbrains.compose.ui.tooling.preview.* (Compose Multiplatform-aware, NOT the Android-only variant).

feature/activate/build.gradle.kts: -implementation(projects.core.domain) + +implementation(projects.core.data) + +implementation(projects.core.ui). No direct coreBase.* deps.

Grep invariants (Wave 1 verification)

Check	Result
grep -rn "DataState|asDataStateFlow" feature/activate/	zero matches
grep -rn "template\.core\.base" feature/activate/	3 matches (KptTheme, SubmitProgressOverlay, SubmitResultHandler — Composables/Theme accessed via api chain; gradle direct deps still zero)
grep -rn "implementation\(projects.coreBase" feature/activate/build.gradle.kts	zero matches
grep -rn "MifosProgressIndicator|MifosSweetError" feature/activate/	zero matches (replaced by framework's SubmitProgressOverlay + SubmitResultHandler)
Files outside {ui, di, navigation}/ in feature/activate/src/commonMain/kotlin/.../activate/	zero

Test plan

• ./gradlew :feature:activate:build compiles cleanly
• ./gradlew :cmp-android:assembleDebug succeeds; Koin DI graph resolves; app boots
• Activate-client flow: tap Activate → SubmitProgressOverlay → Success dialog → onBack
• Activate-center / Activate-group flows: same end-to-end check
• Network error: SubmitProgressOverlay → Failure dialog → dialog dismiss resets handler
• Rapid double-tap: only one submission proceeds (SubmitHandler idempotent during Submitting)
• Compose Multiplatform Preview: ActivateScreenPreview renders in IDE preview pane

Migration template for Waves 2-7

Every subsequent wave follows this same shape. The infrastructure pieces (core/data/store/SubmitTypes, core/ui/store/ViewModelTypes, core/data api routing) are seeded by Wave 1 and Waves 2-7 don't redo them. Per-feature additions:

1. core/network/<resource>/api/XxxApi.kt (new resource if first wave touching it, or new methods on existing API)
2. core/data/<feature>/{XxxRepository.kt, impl/XxxRepositoryImpl.kt} + RepositoryModule registration
3. core/database/<feature>/{dao, entity, mapper}/ (when caching is involved)
4. Delete pure-delegator use cases from core/domain
5. feature/<name>/{ui, di, navigation}/ restructure with BaseViewModel<S, E, A> + framework Composables + @Preview
6. feature/<name>/build.gradle.kts deps: core/data + core/ui only
7. Per-form RoomSubmitOutbox<P> + OfflineSubmitSyncer<P, R> in feature DI for offline-resilient flows (savings, recurringDeposit, loan, client)

Phase status

• ✅ Phase A (infra sync)
• ✅ Phase B (core/store seam)
• 🟢 Phase C Wave 1 (this PR — activate) — end-to-end pattern established
• 🔵 Wave 2 (auth) — next session, chained on this branch
• 🔵 Waves 3-7
• 🔵 Phase D — delete deprecated DataManagers + Services + BaseApiManager + FlowConverterFactory + DataState

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)

• development

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 8cf034c6-9178-4693-a88f-6f6546f66fa5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud