chore(build-logic): add missing dependencies to version catalog & missing build logic files by amanna13 · Pull Request #2572 · openMF/mifos-x-field-officer-app

amanna13 · 2026-01-12T20:55:32Z

Fixes - Jira-#598

chore(build-logic): complete version catalogue and build logic setup

Screen_recording_20260129_195045.mp4

Add missing dependencies to version catalogue
Finalize build logic configuration
Run the static analysis check ./gradlew check or ci-prepush.sh to make sure you didn't break anything
If you have multiple commits please combine them into one commit by squashing them.

coderabbitai · 2026-01-12T20:55:38Z

Important

Review skipped

Too many files!

This PR contains 182 files, which is 32 over the limit of 150.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

🔍 Trigger a full review

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Tip

🧪 Unit Test Generation v2 is now available!

We have significantly improved our unit test generation capabilities.

To enable: Add this to your .coderabbit.yaml configuration:

reviews:
  finishing_touches:
    unit_tests:
      enabled: true

Try it out by using the @coderabbitai generate unit tests command on your code files or under ✨ Finishing Touches on the walkthrough!

Have feedback? Share your thoughts on our Discord thread!

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

- Add missing dependencies to version catalogue - Finalize build logic configuration

biplab1

Looks good to me. This can be merged.

biplab1 · 2026-01-22T15:25:29Z

@amanna13 Have you checked the build on your PR branch? Is the app building fine? Please upload a screen recording in the PR description.

amanna13 · 2026-01-22T15:55:43Z

@amanna13 Have you checked the build on your PR branch? Is the app building fine? Please upload a screen recording in the PR description.

@biplab1 Yes it's building fine, attaching a screen recording soon. The ony issue was, there was a build failure for the demoDebug variant of the client app. You can see that in this PR I have commented out the apply("org.convention.android.application.firebase") inside build-logic > convention > AndroidApplicationConventionPlugin to temporarily fix it.

The actual issue is in cmp-android/google-services.json, there’s no matching Firebase client entry for DemoDebug

biplab1 · 2026-01-23T16:29:08Z

@amanna13 Have you checked the build on your PR branch? Is the app building fine? Please upload a screen recording in the PR description.

@biplab1 Yes it's building fine, attaching a screen recording soon. The ony issue was, there was a build failure for the demoDebug variant of the client app. You can see that in this PR I have commented out the apply("org.convention.android.application.firebase") inside build-logic > convention > AndroidApplicationConventionPlugin to temporarily fix it.

The actual issue is in cmp-android/google-services.json, there’s no matching Firebase client entry for DemoDebug

@amanna13 I think we can handle this issue in a separate ticket. Please create a ticket to update google-services.json and handle this convention plugin error which results in a package name different from that listed in the google-services.json.

amanna13 · 2026-01-23T16:31:45Z

@biplab1 So it's commented out for now. so should i request for a merge ?!

niyajali · 2026-01-23T16:33:53Z

@amanna13 Have you checked the build on your PR branch? Is the app building fine? Please upload a screen recording in the PR description.

@biplab1 Yes it's building fine, attaching a screen recording soon. The ony issue was, there was a build failure for the demoDebug variant of the client app. You can see that in this PR I have commented out the apply("org.convention.android.application.firebase") inside build-logic > convention > AndroidApplicationConventionPlugin to temporarily fix it.

The actual issue is in cmp-android/google-services.json, there’s no matching Firebase client entry for DemoDebug

No, never do that instead copy the google services file from another project(https://github.com/openMF/kmp-project-template/blob/dev/cmp-android/google-services.json) and add these client info

    {
      "client_info": {
        "mobilesdk_app_id": "1:728434912738:android:53d0930e402622611a1dbb",
        "android_client_info": {
          "package_name": "com.mifos.mifosxdroid.demo.debug"
        }
      },
      "oauth_client": [
        {
          "client_id": "728434912738-4sc51o624viccn8oi14f2mi77tljrdns.apps.googleusercontent.com",
          "client_type": 3
        }
      ],
      "api_key": [
        {
          "current_key": "AIzaSyCUz3P8uUExMFcPHa1Ga3DBKhjK5zxNn70"
        }
      ],
      "services": {
        "appinvite_service": {
          "other_platform_oauth_client": [
            {
              "client_id": "728434912738-4sc51o624viccn8oi14f2mi77tljrdns.apps.googleusercontent.com",
              "client_type": 3
            }
          ]
        }
      }
    },
    {
      "client_info": {
        "mobilesdk_app_id": "1:728434912738:android:53d0930e402622611a1dbb",
        "android_client_info": {
          "package_name": "com.mifos.mifosxdroid.debug"
        }
      },
      "oauth_client": [
        {
          "client_id": "728434912738-4sc51o624viccn8oi14f2mi77tljrdns.apps.googleusercontent.com",
          "client_type": 3
        }
      ],
      "api_key": [
        {
          "current_key": "AIzaSyCUz3P8uUExMFcPHa1Ga3DBKhjK5zxNn70"
        }
      ],
      "services": {
        "appinvite_service": {
          "other_platform_oauth_client": [
            {
              "client_id": "728434912738-4sc51o624viccn8oi14f2mi77tljrdns.apps.googleusercontent.com",
              "client_type": 3
            }
          ]
        }
      }
    },

niyajali · 2026-01-23T16:41:46Z

And there are some recent changes in the template project, take a look into that and do the required changes accordingly

amanna13 · 2026-01-25T11:22:52Z

Hey @niyajali, I tried with what you suggested with the google-services and it did work.

I'm keeping Crashlytics true, its currently set on true for mifos-mobile but it was false in android-client

And there are some recent changes in the template project, take a look into that and do the required changes accordingly

Let's keep it what we are currently doing for now, because of this PR the core-base haven't merged yet and a lot of other PR's are waiting for that.
Dependency updates and all can be addressed once this is merged in a seperate PR, because a lot of dependencies like "room" was upgraded which introduced stricter type validation, which is currently failing I checked.

biplab1 · 2026-01-26T14:43:52Z

@amanna13 I am curious - since you might have built using both the settings:

Does the compile and build times for debug variant build gets affected? Can you verify this:

Then those need to be updated to improve the build and compile time for debug builds

amanna13 · 2026-01-26T17:48:24Z

Does the compile and build times for debug variant build gets affected?

@biplab1 I verified the Debug build performance by running in the same environment. With mappingFileUpload enabled, the Debug build took ~5m 30s, compared to ~3m 52s when disabled, somewhat close to 30% improvement

biplab1 · 2026-01-27T14:15:00Z

Does the compile and build times for debug variant build gets affected?

@biplab1 I verified the Debug build performance by running in the same environment. With mappingFileUpload enabled, the Debug build took ~5m 30s, compared to ~3m 52s when disabled, somewhat close to 30% improvement

@amanna13 I am assuming you did a clean build before testing each of the settings.

Please keep the mappingFileUpload disabled for now in this project, other projects which have it enabled will also be disabled as recommended by @niyajali .

Can you also address this as pointed out by @niyajali:

And there are some recent changes in the template project, take a look into that and do the required changes accordingly

For dependencies, I think we can update them to a version where the changes in the project are minimal and manageable at the current moment.

amanna13 · 2026-01-27T14:21:54Z

I am assuming you did a clean build before testing each of the settings.

Yes I did clean build. Okay sure I will disable that.

For dependencies, I think we can update them to a version where the changes in the project are minimal and manageable at the current moment.

Yeah, that will work, it will take me one more day to do so. I was saying previously to merge this as it is, keeping in mind the priority of this task.

biplab1 · 2026-01-27T14:49:59Z

@amanna13 If you face any problems, feel free to start a Slack thread tagging @niyajali and me to expedite the work on this PR.

…pport on android

amanna13 · 2026-01-29T14:32:54Z

@biplab1 Done with all the updations. please have a look.
(Screen recording after build updated).

biplab1

Looks good to me. This can be merged.

…ript) — no new files Per review feedback: the right place for this fix is the sync-dirs flow itself, not a separate workflow that runs after-the-fact. Removed the dedicated workflow + companion script from the previous commit; integrated the logic inline into both .github/workflows/sync-dirs.yaml and sync-dirs.sh. What changed vs the previous commit on this branch (ceb1a79): - DELETED .github/workflows/verify-libs-resolved.yml (-52 lines) - DELETED scripts/verify_libs_resolved.sh (-180 lines) + .github/workflows/sync-dirs.yaml — new step "Heal libs.versions.toml" between "Sync directories and files" and "Clean up temporary branch". Runs the same detection logic, but instead of just failing the gate, it AUTO-PULLS the missing alias entries (and any version.ref keys they depend on) directly from the upstream catalog accessible via $TEMP_BRANCH. The healed catalog is then committed as part of the same sync PR — no separate fix-up PR ever needed. + sync-dirs.sh — new heal_libs_versions_toml() function invoked between the sync loop and temp-branch cleanup. Same heal semantics for local CLI use. The downstream `git add` is widened to include gradle/libs.versions.toml when the heal touched it. Behavior: 1. Sync-dirs pulls build-logic from upstream (existing behavior, unchanged) 2. Heal step inspects every libs.<X> reference in the freshly-synced build-logic 3. For each ref whose alias is missing from consumer's gradle/libs.versions.toml, pull the matching line from upstream (TEMP_BRANCH) and insert it into the appropriate [versions] / [libraries] / [plugins] section 4. If an alias version.refs an undeclared version key, that version key is also pulled and inserted into [versions] BEFORE the alias 5. Healed entries land in the same sync PR — discovery + remediation in one atomic workflow run, instead of a "fails-now-fix-tomorrow" split Verified against field-officer's pre-fix state (catalog reverted to commit 408d9cba — the broken state from ~24h ago, before the manual #2691 catch-up): - Pre-heal: 5 missing aliases — kover-gradlePlugin, kover-convention, androidx-room-gradle-plugin, kmp-product-flavors-plugin, spotless-gradle - Post-heal: 7 entries inserted (5 aliases + 2 referenced versions kmpProductFlavors, kover). All build-logic libs.<X> refs resolve. Eliminates the failure mode that's been hand-fixed at least 3 times in 4 months on the field-officer fork (openMF/mifos-x-field-officer-app#2572, #2604, #2691).

amanna13 force-pushed the chore/sync-version-catalogue-buildlogic branch 2 times, most recently from 0f2fe17 to b70a147 Compare January 16, 2026 14:03

amanna13 marked this pull request as ready for review January 16, 2026 14:06

amanna13 marked this pull request as draft January 16, 2026 14:16

chore(build-logic): complete version catalogue and build logic setup

6c41344

- Add missing dependencies to version catalogue - Finalize build logic configuration

amanna13 force-pushed the chore/sync-version-catalogue-buildlogic branch from b70a147 to 6c41344 Compare January 16, 2026 14:24

amanna13 marked this pull request as ready for review January 16, 2026 14:43

itsPronay reviewed Jan 16, 2026

View reviewed changes

Comment thread build-logic/convention/build.gradle.kts

itsPronay requested a review from HekmatullahAmin January 16, 2026 16:20

biplab1 approved these changes Jan 22, 2026

View reviewed changes

Merge branch 'development' into chore/sync-version-catalogue-buildlogic

1fa1417

biplab1 reviewed Jan 24, 2026

View reviewed changes

Comment thread build-logic/convention/src/main/kotlin/AndroidApplicationFirebaseConventionPlugin.kt

fix: addressed changes in google-services.json and crashlytics

8da4065

amanna13 requested review from biplab1 and niyajali January 26, 2026 10:24

amanna13 added 2 commits January 28, 2026 10:13

fix: Disabled crashlytics mapping file upload for faster builds

cfcc0cb

fix(workflows): correct sync directories workflow for scheduled runs

bc3795f

amanna13 added 4 commits January 29, 2026 02:02

chore: updates and add support for ios language set support

b3ffce5

fix: fixed build failures

05bec7f

fix: update local handling across all platforms and per app locale su…

ecd6082

…pport on android

Merge branch 'development' into chore/sync-version-catalogue-buildlogic

7a969bc

biplab1 reviewed Jan 30, 2026

View reviewed changes

Comment thread gradle.properties

biplab1 approved these changes Jan 30, 2026

View reviewed changes

Merge branch 'development' into chore/sync-version-catalogue-buildlogic

eb241b0

therajanmaurya merged commit b7ae284 into openMF:development Jan 30, 2026
3 checks passed

therajanmaurya mentioned this pull request May 22, 2026

fix(sync-dirs): self-heal libs.versions.toml when upstream adds build-logic aliases openMF/kmp-project-template#163

Merged

7 tasks

Uh oh!

Conversation

amanna13 commented Jan 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

chore(build-logic): complete version catalogue and build logic setup

Uh oh!

coderabbitai Bot commented Jan 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

Uh oh!

biplab1 left a comment

Choose a reason for hiding this comment

Uh oh!

biplab1 commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

amanna13 commented Jan 22, 2026

Uh oh!

biplab1 commented Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

amanna13 commented Jan 23, 2026

Uh oh!

niyajali commented Jan 23, 2026

Uh oh!

niyajali commented Jan 23, 2026

Uh oh!

Uh oh!

amanna13 commented Jan 25, 2026

Uh oh!

biplab1 commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

amanna13 commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

biplab1 commented Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

amanna13 commented Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

biplab1 commented Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

amanna13 commented Jan 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

biplab1 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

amanna13 commented Jan 12, 2026 •

edited

Loading

coderabbitai Bot commented Jan 12, 2026 •

edited

Loading

biplab1 commented Jan 22, 2026 •

edited

Loading

biplab1 commented Jan 23, 2026 •

edited

Loading

biplab1 commented Jan 26, 2026 •

edited

Loading

amanna13 commented Jan 26, 2026 •

edited

Loading

biplab1 commented Jan 27, 2026 •

edited

Loading

amanna13 commented Jan 27, 2026 •

edited

Loading

biplab1 commented Jan 27, 2026 •

edited

Loading

amanna13 commented Jan 29, 2026 •

edited

Loading