Skip to content

fix notes screen issue - #2485

Merged
therajanmaurya merged 12 commits into
openMF:developmentfrom
Arinyadav1:fix-notes_screen_issue
Sep 3, 2025
Merged

fix notes screen issue#2485
therajanmaurya merged 12 commits into
openMF:developmentfrom
Arinyadav1:fix-notes_screen_issue

Conversation

@Arinyadav1

@Arinyadav1 Arinyadav1 commented Sep 1, 2025

Copy link
Copy Markdown
Member

Fixes - Jira-#588

It fix the issue note list not update immediately after update and add note.

Comment thread feature/note/src/commonMain/kotlin/com/mifos/feature/note/notes/NoteScreen.kt Outdated
@Arinyadav1

Copy link
Copy Markdown
Member Author

@itsPronay

what happens ?

@itsPronay

itsPronay commented Sep 2, 2025

Copy link
Copy Markdown
Member

@Arinyadav1 Please make the following changes, see other screens for reference

  1. Remove custom Note Empty Screen that you made as we already have this component. Use MifosEmptyCard,
  2. Move Note Compoents to com.mifos.core.ui.components, we already have similar design, follow its style, no need to start from scratch, it just gives extra code.
  3. This should go inside the dialogState, all the dialog related things go inside dialogState, we don;t need another state variable for this
image

@Arinyadav1

Copy link
Copy Markdown
Member Author

@itsPronay
MifosEmptyCard, does not have shape elevation then how can I use it instead custom Note Empty Screen

@itsPronay

Copy link
Copy Markdown
Member

shape ? elevation? I don't see Empty screen having shave and elevation in figma screen. why do you need it when every empty screen looks the same.

Comment thread feature/note/src/commonMain/kotlin/com/mifos/feature/note/notes/NoteScreen.kt Outdated
@Arinyadav1

Copy link
Copy Markdown
Member Author

@itsPronay

Remove custom Note Empty Screen that you made as we already have this component. Use MifosEmptyCard,

please understand we about it what you want to change.

@therajanmaurya
therajanmaurya enabled auto-merge (squash) September 3, 2025 07:50
@therajanmaurya
therajanmaurya merged commit 855974c into openMF:development Sep 3, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants