fix(feat:client-identifiers): fix dialog visibility issues for creating client identifiers - #2449
fix(feat:client-identifiers): fix dialog visibility issues for creating client identifiers#2449sam-arth07 wants to merge 6 commits into
Conversation
…ng client identifiers
|
Target branch is |
|
@sam-arth07 There seems to be two consecutive loading states — one in the dialog and another in the main screen after a successful submission. (see video at 13-15 seconds)
|
|
@sam-arth07 The expected behavior is that the dialog should close immediately after submission (without showing any loading), and the loading indicator should appear only on the main screen while fetching the updated list. Currently, the opposite is happening: the dialog shows the loading state, while the main screen does not. |
biplab1
left a comment
There was a problem hiding this comment.
Please update the PR description with all the changes made, and fix the one minor change requested below. The rest looks good to me, and this can be merged.
|
Closing in response of #2450 |


Fixes - MIFOSAC-498
Changes made in the PR:
Refactored dialog visibility logic for creating client identifiers:
Standardized success/error feedback: show toast on successful identifier creation and error UI on failures, all driven by a single sealed UI state and SharedFlow events.
Issue: Delete Identifier flow showed Loading twice;
Screenshots
Issue: Pull-to-refresh didn’t trigger loading on main screen; data refreshed silently.
Testing notes
Before:
before.mp4
After:
finalSol.mp4
Please make sure these boxes are checked before submitting your pull request - thanks!
Run the static analysis check
./gradlew checkorci-prepush.shto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.