refactor(feature:client): merge ViewModels, add charge validation, fix empty chargeOptions crash - #2430
Conversation
|
Note: Merge this after #2428 |
|
@biplab1 I think for now we can focus only on the issues that are crashing the application or any api error handling things, because @niyajali @revanthkumarJ @itsPronay your thoughts on this |
I also think same like when i see mifos-mobile or template we have used Actions , Events , BaseViewModel and some neat architecture |
|
@Nagarjuna0033 @revanthkumarJ Just to clarify — the feature wasn’t fully working before. It was crashing when So the snackbar, state reset, and dialog refactor are not just polish — they fix real flow blockers and ensure the screen stays stable as we transition to the new UI. Skipping these now risks the same crash or broken flow later. |
5e097f3 to
9d9ecff
Compare
9d9ecff to
7d190f5
Compare
cd3abe6 to
11b3b28
Compare
430bda4 to
fd12819
Compare
|
@Nagarjuna0033 @revanthkumarJ @itsPronay @Aditya3815 @HekmatullahAmin Guys review this |
fc35b6d to
5d91342
Compare
|
@niyajali I’ve merged the two view models as discussed. Please let me know if anything else needs to be done. If everything looks good, kindly go ahead and merge it. |
…x empty chargeOptions crash (openMF#2430) Co-authored-by: Sk Niyaj Ali <niyaj639@gmail.com>
…x empty chargeOptions crash (openMF#2430) Co-authored-by: Sk Niyaj Ali <niyaj639@gmail.com>
Fixes - Jira-#458
Summary of Changes:
ChargeDialogUiState.AllChargesV2whenchargeOptionsis empty.Before Fix (without charges setup in web-app):
before-fix-client-charges-dialog.mp4
Before Fix (with charges setup in web-app and no database bypass):
before-fix-client-charges-dialog-no-charge-setup-no-database-bypass.webm
After Fix:
Note:
(the database handling is a work in progress in another PR)
Client-Charges-Dialog-Merge-Viewmodels.mp4
Please make sure these boxes are checked before submitting your pull request - thanks!
Run the static analysis check
./gradlew checkorci-prepush.shto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.