Skip to content

fix(navigation) : back navigation registers search screen successfully. - #2408

Merged
niyajali merged 2 commits into
openMF:kmp-implfrom
sam-arth07:MIFOSAC-454
Jun 19, 2025
Merged

fix(navigation) : back navigation registers search screen successfully.#2408
niyajali merged 2 commits into
openMF:kmp-implfrom
sam-arth07:MIFOSAC-454

Conversation

@sam-arth07

Copy link
Copy Markdown
Contributor

Fixes - Jira-#454

Screenshots

NavIssueFixed.webm

Description

What’s Achieved in This PR

  1. Fixed back navigation not working when navigating from search screen to drawer screens: Resolved issue where clicking back from Settings/About screens would close the app instead of returning to search screen
  2. Fixed search screen not being properly registered in navigation controller stack: Search screen now properly maintains its position in the navigation stack.
  3. Fixed search screen icon not highlighting even when on the search screen.

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the static analysis check ./gradlew check or ci-prepush.sh to make sure you didn't break anything

  • If you have multiple commits please combine them into one commit by squashing them.

@revanthkumarJ

Copy link
Copy Markdown
Contributor

@sam-arth07 update the branch

@biplab1

biplab1 commented Jun 19, 2025

Copy link
Copy Markdown
Contributor

@niyajali When you get a chance, please do a final review and merge if everything looks good.

@niyajali
niyajali enabled auto-merge (squash) June 19, 2025 18:32
@niyajali
niyajali merged commit 210bf86 into openMF:kmp-impl Jun 19, 2025
2 checks passed
itsPronay pushed a commit to itsPronay/android-client that referenced this pull request Aug 5, 2025
itsPronay pushed a commit to itsPronay/android-client that referenced this pull request Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants