-
Notifications
You must be signed in to change notification settings - Fork 789
feature/MM/437-development_onboarding_doc #3003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
feature/MM/437-development_onboarding_doc #3003
Conversation
WalkthroughAdds onboarding-language documentation and a new SetOnboardingLanguageViewModel to manage onboarding language selection, subscription to repository language changes, persistence of chosen language, UI state updates, and internal action/event/state scaffolding. Changes
Sequence Diagram(s)sequenceDiagram
participant UI as UI Layer
participant VM as SetOnboardingLanguageViewModel
participant Repo as Language Repository
participant Storage as Data Layer
rect rgb(230,245,255)
UI->>VM: Initialize ViewModel
VM->>Repo: Subscribe to language stream
Repo-->>VM: Emit current language
VM-->>UI: Emit OnboardingLanguageState
end
rect rgb(235,255,230)
UI->>VM: User selects language
VM->>Storage: Persist selected language
Storage-->>VM: Persist confirmation
VM->>VM: Dispatch Internal(LoadLanguage) / disable onboarding flags
VM-->>UI: Update OnboardingLanguageState (new language)
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
docs/images/graphs/dep_graph_feature_onboarding_language.svgis excluded by!**/*.svg
📒 Files selected for processing (2)
feature/onboarding-language/README.md(1 hunks)feature/onboarding-language/src/commonMain/kotlin/org/mifos/mobile/feature/onboarding/language/SetOnboardingLanguageViewModel.kt(3 hunks)
Removed user action flow for continuing to the next screen.
|
@SCHsebastian try |
Fixes - [Jira-#Issue_Number](https://mifosforge.jira.com/browse/MM-)
Didn't create a Jira ticket, click here to create new.
Please Add Screenshots If there are any UI changes.
Please make sure these boxes are checked before submitting your pull request - thanks!
Run the static analysis check
./gradlew checkorci-prepush.shto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.
Summary by CodeRabbit
New Features
Documentation
✏️ Tip: You can customize this high-level summary in your review settings.