feat: add semantic conventions for gce instance labels#2617
feat: add semantic conventions for gce instance labels#2617paulojmdias wants to merge 9 commits intoopen-telemetry:mainfrom
Conversation
Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>
paulojmdias
changed the title
ridwanmsharif
left a comment
ridwanmsharif
left a comment
There was a problem hiding this comment.
Makes sense to me from the GCP side of things. Will wait for semconv approvers for a review
thompson-tomo
left a comment
thompson-tomo
left a comment
There was a problem hiding this comment.
I feel that we should add this to the host namespace for maximum interoperability and work towards phasing out the dedicated gce namespace as the need is currently very low.
| - id: gcp.gce.instance.labels | ||
| type: template[string] | ||
| stability: development | ||
| brief: > | ||
| GCE instance labels, `<key>` being the label name and the value being the label value. | ||
| note: > | ||
| For example, a GCE instance label `env` with value `prod` SHOULD be recorded as the | ||
| `gcp.gce.instance.labels.env` attribute with value `"prod"`. | ||
| The `<key>` MUST be the exact GCE instance label key. | ||
| examples: [ 'prod' ] |
There was a problem hiding this comment.
Would prefer to see this in the host namespace given the reusability potential.
There was a problem hiding this comment.
This is against the direction we're taking in the entities SIG
There was a problem hiding this comment.
Understood, either way, I also updated the example to be something more agnostic than the environment
|
This seems highly related to a new SIG forming - open-telemetry/community#2837 I'm supportive of adding these labels now, but I also think we should track the long term direction here, as there may be other places we want these labels. |
Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>
Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
/label never-stale -stale |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
/label -stale never-stale |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
/label -stale |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
This PR has been labeled as stale due to lack of activity. It will be automatically closed if there is no further activity over the next 7 days. |
|
/label -stale |
|
This PR has been labeled as stale due to lack of activity. It will be automatically closed if there is no further activity over the next 7 days. |
|
/label -stale |
|
This PR has been labeled as stale due to lack of activity. It will be automatically closed if there is no further activity over the next 7 days. |
|
/label -stale |
|
This PR has been labeled as stale due to lack of activity. It will be automatically closed if there is no further activity over the next 7 days. |
|
/label -stale |
|
This PR has been labeled as stale due to lack of activity. It will be automatically closed if there is no further activity over the next 7 days. |
|
/label -stale |
lmolkova
moved this from Untriaged
to Needs More Approval
in Semantic Conventions Triage
lmolkova
moved this from Needs More Approval
to Ready to be Merged
in Semantic Conventions Triage
6 participants
Relates to open-telemetry/opentelemetry-collector-contrib#41919
Changes
This change introduces a new templated attribute for Google Compute Engine instance labels.
The attribute prefix gcp.gce.instance.labels. follows the existing GCP/GCE naming scheme and aligns with current semantic conventions for similar resources (e.g., container.label).
Merge requirement checklist
[chore]