docs: clarify resource describes observed entity, not telemetry emitter#4905
Merged
jsuereth merged 2 commits intoopen-telemetry:mainfrom Mar 16, 2026
Merged
Conversation
38a63d1 to
aedda40
Compare
florianl
approved these changes
Feb 27, 2026
Member
|
@svencowart, could you please add a changelog entry? |
Disambiguates the Resource definition to account for auto-instrumentation scenarios (e.g., eBPF agents) where the technical producer of telemetry differs from the entity being observed. - specification/resource/README.md: reframe definition as "entity for which telemetry is being produced"; add NOTE callout explaining that Resource MUST describe the observed workload in agent-based instrumentation, with guidance on telemetry.sdk.name / telemetry.distro.name - specification/resource/data-model.md: align definition language; explicitly note the observed entity vs. emitter distinction - specification/resource/sdk.md: same alignment for the SDK spec - specification/logs/data-model.md: update table description from "source of the log" to "observed entity that generated the log"
aedda40 to
8a637d6
Compare
Contributor
Author
|
@pellared done. |
pellared
approved these changes
Mar 2, 2026
MrAlias
approved these changes
Mar 4, 2026
reyang
approved these changes
Mar 4, 2026
carlosalberto
approved these changes
Mar 6, 2026
Member
|
Its both though isn't it? At least in the case of the telemetry SDK attributes they reference the SDK which is monitoring the process. Admittedly it is a bit of an odd case because the SDK is a part of the process being monitored as well. |
jsuereth
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4903
Changes
Disambiguates the Resource definition to account for auto-instrumentation scenarios (e.g., eBPF agents) where the technical producer of telemetry differs from the entity being observed.
CHANGELOG.mdfile updated for non-trivial changes[chore]in the PR title to skip the changelog check