[Prototype] spaneventbridge: add processor that bridges log-based events back onto the current span as span events#8760
Conversation
…e current span as span events
| return attrs | ||
| } | ||
|
|
||
| func spanAttribute(kv log.KeyValue) attribute.KeyValue { |
There was a problem hiding this comment.
Note that this won't be needed when Logs API is going to use attribute
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8760 +/- ##
=======================================
- Coverage 83.4% 83.2% -0.3%
=======================================
Files 192 193 +1
Lines 15598 15722 +124
=======================================
+ Hits 13024 13088 +64
- Misses 2127 2185 +58
- Partials 447 449 +2
🚀 New features to boost your workflow:
|
dashpole
left a comment
There was a problem hiding this comment.
I like this design a lot. I would consider spaneventbridge as a name.
|
I think it’s quite good overall. One additional small suggestion: Since log reporting needs to be tracked based on the
|
We may want to improve the https://pkg.go.dev/go.opentelemetry.io/otel/log#Logger docs. Note that some log records may be emitted outside of any span. |
Per https://github.com/open-telemetry/opentelemetry-specification/blob/main/oteps/4430-span-event-api-deprecation-plan.md#via-the-sdk Declarative configuration PR: - open-telemetry/opentelemetry-configuration#588 Prototypes: - Java: https://github.com/open-telemetry/opentelemetry-java-contrib/blob/42fea9d335c9a53089996fa5888e06926f6f4a5c/processors/README.md#event-to-spanevent-bridge - Go: open-telemetry/opentelemetry-go-contrib#8760
Per https://github.com/open-telemetry/opentelemetry-specification/blob/main/oteps/4430-span-event-api-deprecation-plan.md#via-the-sdk Declarative configuration PR: - open-telemetry/opentelemetry-configuration#588 Prototypes: - Java: https://github.com/open-telemetry/opentelemetry-java-contrib/blob/42fea9d335c9a53089996fa5888e06926f6f4a5c/processors/README.md#event-to-spanevent-bridge - Go: open-telemetry/opentelemetry-go-contrib#8760
Prototype for https://github.com/open-telemetry/opentelemetry-specification/blob/main/oteps/4430-span-event-api-deprecation-plan.md#sending-log-based-exceptions-and-events-as-span-events
Based on https://github.com/open-telemetry/opentelemetry-java-contrib/blob/80adbe1cf8de647afa32c68f921aef2bbd4dfd71/processors/src/main/java/io/opentelemetry/contrib/eventbridge/EventToSpanEventBridge.java
@open-telemetry/go-maintainers, asking for an overall review of the prototype. I do not want to merge this at this point of time.