refactor(opentelemetry_redix): align with Redis database SemConv#660
Open
yordis wants to merge 1 commit intoopen-telemetry:mainfrom
Open
refactor(opentelemetry_redix): align with Redis database SemConv#660yordis wants to merge 1 commit intoopen-telemetry:mainfrom
yordis wants to merge 1 commit intoopen-telemetry:mainfrom
Conversation
yordis
force-pushed
the
yordis/redix-1
branch
5 times, most recently
from
e669635 to
76734d3
Compare
- Replaces deprecated `db.system`, `db.operation`, `db.statement`, `net.peer.name/port` with current SemConv: `db.system.name`, `db.operation.name`, `db.query.text`, `server.address`, `server.port` - Omits `server.port` when it equals the Redis default (6379) - Adds `db_namespace` option mapping to `db.namespace` attribute - Improves pipeline span naming from `"pipeline"` to `"PIPELINE GET SET ..."` - Adds `db.operation.batch_size` for pipeline commands - Adds `db.response.status_code` and `error.type` on Redis errors - Detaches telemetry handler in test teardown to prevent cross-test leakage Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
db.system,db.operation,db.statement,net.peer.name/portwith current SemConv:db.system.name,db.operation.name,db.query.text,server.address,server.portserver.portwhen it equals the Redis default (6379)db_namespaceoption mapping todb.namespaceattribute"pipeline"to"PIPELINE GET SET ..."db.operation.batch_sizefor pipeline commandsdb.response.status_codeanderror.typeon Redis errors