Tooling to benchmark wire messages#120
Open
rockdaboot wants to merge 11 commits intoopen-telemetry:mainfrom
Open
Tooling to benchmark wire messages#120rockdaboot wants to merge 11 commits intoopen-telemetry:mainfrom
rockdaboot wants to merge 11 commits intoopen-telemetry:mainfrom
Conversation
rockdaboot
force-pushed
the
benchmark-wire-protocol
branch
from
87bb8d7 to
1844cf7
Compare
athre0z
reviewed
Aug 15, 2024
Member
athre0z
left a comment
athre0z
left a comment
There was a problem hiding this comment.
Looks promising -- added a few comments!
athre0z
reviewed
Aug 15, 2024
rockdaboot
force-pushed
the
benchmark-wire-protocol
branch
from
41d3141 to
2c5f92b
Compare
rockdaboot
force-pushed
the
benchmark-wire-protocol
branch
from
9e556ca to
7c62ff7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a PoC/RFC for #110.
The PR adds three new options to the profiling agent
-reporter-record-inputs-to=<FILE>to record all internal data passed to thereporterinto the given NDJSON file.-reporter-replay-inputs-from=<FILE>replays the data from the given NDJSON file.-reporter-save-outputs-to=<DIR>records all wire messages uncompressed into the given directory, one file per message.The PR also adds
tools/protobenchthat allows compressing the wire messages recorded by the profiling agent with different compression algorithms and levels. The compressors are all imported as Go dependencies (external tools are not used), as that is what the profiling agent would use. The results can be output as CSV or as PNG file (bar chart).This should combine with prior work from @petethepig (see https://docs.google.com/spreadsheets/d/1Q-6MlegV8xLYdz5WD5iPxQU2tsfodX1-CDV1WeGzyQ0/edit?gid=1732807979#gid=1732807979)