Skip to content

[chore][processor/resourcedetection] Unexport GCElabelPrefix and increase GCE labels test coverage#45852

Merged
mx-psi merged 6 commits intoopen-telemetry:mainfrom
paulojmdias:fix/gcp_detect
Feb 4, 2026
Merged

[chore][processor/resourcedetection] Unexport GCElabelPrefix and increase GCE labels test coverage#45852
mx-psi merged 6 commits intoopen-telemetry:mainfrom
paulojmdias:fix/gcp_detect

Conversation

@paulojmdias
Copy link
Copy Markdown
Member

@paulojmdias paulojmdias commented Feb 3, 2026

Description

After my PR #41919 was merged, I feel some improvements could be made related to it.

This PR does not change any behaviour for the users and includes the following changes:

  • Un-export GCElabelPrefix renaming it to gceLabelPrefix
  • Update log format when reading metadata for labels fails
  • Increase test coverage, including using invalid regex patterns

…rease GCE labels test coverage

Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>
@paulojmdias paulojmdias requested review from a team and dashpole as code owners February 3, 2026 22:35
@github-actions github-actions Bot added the processor/resourcedetection Resource detection processor label Feb 3, 2026
@github-actions github-actions Bot requested a review from Aneurysm9 February 3, 2026 22:35
Copy link
Copy Markdown
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the timeout change should have a changelog entry since it may result in hard to debug behavior for some deployments

…-contrib into fix/gcp_detect

Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>
Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>
…-collector-contrib into fix/gcp_detect

Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>
@paulojmdias
Copy link
Copy Markdown
Member Author

I think the timeout change should have a changelog entry since it may result in hard to debug behavior for some deployments

I'll move it to a different PR for easier review 👍

@paulojmdias paulojmdias changed the title [chore][processor/resourcedetection] Remove hardcoded timeout and increase GCE labels test coverage [chore][processor/resourcedetection] Unexport GCElabelPrefix and increase GCE labels test coverage Feb 4, 2026
Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>
@mx-psi mx-psi merged commit d76ad9d into open-telemetry:main Feb 4, 2026
191 checks passed
@paulojmdias paulojmdias deleted the fix/gcp_detect branch February 4, 2026 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

processor/resourcedetection Resource detection processor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants