[chore][processor/resourcedetection] Unexport GCElabelPrefix and increase GCE labels test coverage#45852
Merged
mx-psi merged 6 commits intoopen-telemetry:mainfrom Feb 4, 2026
Merged
Conversation
…rease GCE labels test coverage Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>
mx-psi
reviewed
Feb 4, 2026
Member
mx-psi
left a comment
There was a problem hiding this comment.
I think the timeout change should have a changelog entry since it may result in hard to debug behavior for some deployments
…-contrib into fix/gcp_detect Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>
Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>
…-collector-contrib into fix/gcp_detect Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>
Member
Author
I'll move it to a different PR for easier review 👍 |
Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>
mx-psi
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After my PR #41919 was merged, I feel some improvements could be made related to it.
This PR does not change any behaviour for the users and includes the following changes:
GCElabelPrefixrenaming it togceLabelPrefix