Externalize builder package to pkg/builder #248
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move internal/builder to pkg/builder to provide a public API for OPA bundle compilation. This allows external users to build bundles from multiple sources with namespace isolation. Changes: - Move internal/builder -> pkg/builder - Create pkg/builder/config.go for public configuration types - Requirement: source dependencies with path mounting - Dir: directory configuration with filters - Transform: Rego query transformations - Add comprehensive documentation in pkg/builder/doc.go - Update internal/service to use pkg/builder - Convert internal config.Requirement to builder.Requirement Public API: - Builder: fluent builder with Build method - Source: represents policy/data sources - Requirement: minimal dependency type (no internal deps) - Dir, Transform: configuration types - PackageConflictErr: namespace conflict error All tests passing. External users can now use pkg/builder without importing any internal packages. Signed-off-by: Yi Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move internal/builder to pkg/builder to provide a public API for OPA bundle compilation. This allows external users to build bundles from multiple sources with namespace isolation.
Changes:
Public API:
All tests passing. External users can now use pkg/builder without importing any internal packages.