CMake: define digidocpp_EXPORTS for static builds

[lnagel]

Summary

• When BUILD_SHARED_LIBS=OFF on Windows, CMake does not define digidocpp_EXPORTS on the digidocpp target (only done automatically for shared libraries)
• This causes DIGIDOCPP_EXPORT in Exports.h to resolve to __declspec(dllimport) instead of __declspec(dllexport)
• Applies the same pattern already used for digidocpp_util and digidocpp_tsl (line 83-84): sets COMPILE_DEFINITIONS digidocpp_EXPORTS on the target for static builds

Test plan

• Build with BUILD_SHARED_LIBS=OFF on Windows — DIGIDOCPP_EXPORT should resolve to __declspec(dllexport)
• Build with BUILD_SHARED_LIBS=ON on Windows — no change, CMake defines digidocpp_EXPORTS automatically

[metsma]

Something is still missing:

LINK Pass 1: command "C:\PROGRA~1\MICROS~2\2022\ENTERP~1\VC\Tools\MSVC\1444~1.352\bin\Hostx64\x64\link.exe /nologo @CMakeFiles\digidoc_java.dir\objects1.rsp /out:digidoc_javad.dll /implib:digidoc_javad.lib /pdb:D:\a\libdigidocpp\libdigidocpp\x64Debug\src\digidoc_javad.pdb /dll /version:0.0 /guard:cf /machine:x64 /debug /INCREMENTAL digidocppd.lib digidocpp_utild.lib kernel32.lib user32.lib gdi32.lib winspool.lib shell32.lib ole32.lib oleaut32.lib uuid.lib comdlg32.lib advapi32.lib /MANIFEST /MANIFESTFILE:CMakeFiles\digidoc_java.dir/intermediate.manifest CMakeFiles\digidoc_java.dir/manifest.res" failed (exit code 1120) with the following output:
   Creating library digidoc_javad.lib and object digidoc_javad.exp
libdigidocppJAVA_wrap.cxx.obj : error LNK2001: unresolved external symbol "public: static class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const digidoc::Signature::POLv1" (?POLv1@Signature@digidoc@@2V?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@B)
libdigidocppJAVA_wrap.cxx.obj : error LNK2001: unresolved external symbol "public: static class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const digidoc::Signature::POLv2" (?POLv2@Signature@digidoc@@2V?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@B)

[lnagel]

Which command is this from? I see that CI checks are all successful. I have personally no way to replicate it.

[metsma]

Seems like powershell hides windows build failures.
I discovered warning in github actions and then looked the windows builds
No files were found with the provided path: ./*.msi. No artifacts will be uploaded.
Maybe we can add one simple static windows build to verify all of this to avoid future breakage?

[lnagel]

I agree that a static build on GitHub actions would be a good idea. Maybe if you add this on master then I can rebase?

[metsma]

We are currently in code freeze

[lnagel]

What would you suggest then?

[metsma]

If you do not mind I can use your branch?

[lnagel]

Yes, both of my PRs have maintainer edits enabled.