Skip to content

📖 Update addon template variables doc #496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

zhujian7
Copy link
Member

@zhujian7 zhujian7 commented Jun 24, 2025

Fix #495

Copy link

netlify bot commented Jun 24, 2025

Deploy Preview for open-cluster-management ready!

Name Link
🔨 Latest commit ebaf78c
🔍 Latest deploy log https://app.netlify.com/projects/open-cluster-management/deploys/685a711f9489f900082d1974
😎 Deploy Preview https://deploy-preview-496--open-cluster-management.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@openshift-ci openshift-ci bot requested review from dhaiducek and xuezhaojun June 24, 2025 09:33
- Add detailed explanation of built-in vs customized variables
- Provide comprehensive examples of using AddOnDeploymentConfig variables
- Include step-by-step guide for defining and using customized variables
- Add variable naming conventions and validation rules
- Explain variable precedence order
- Include practical examples for different environments (dev/prod)
- Add common use cases for variables

Fixes open-cluster-management-io#495

Signed-off-by: zhujian <[email protected]>
@zhujian7 zhujian7 force-pushed the update-addon-template-variables-doc branch from 5465130 to ebaf78c Compare June 24, 2025 09:34
@zhujian7
Copy link
Member Author

/hold

@qiujian16
Copy link
Member

/approve
/lgtm
/unhold

Copy link
Contributor

openshift-ci bot commented Jun 25, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, zhujian7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit ad4c9d7 into open-cluster-management-io:main Jun 25, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the addonTemplate doc to better describe how to use variables
2 participants