Skip to content

add placement cel examples #474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

haoqing0110
Copy link
Member

@haoqing0110 haoqing0110 commented May 12, 2025

@openshift-ci openshift-ci bot requested review from dhaiducek and mikeshng May 12, 2025 09:27
Copy link

netlify bot commented May 12, 2025

Deploy Preview for open-cluster-management ready!

Name Link
🔨 Latest commit a0fdf43
🔍 Latest deploy log https://app.netlify.com/sites/open-cluster-management/deploys/6822fd123890d70008438734
😎 Deploy Preview https://deploy-preview-474--open-cluster-management.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@haoqing0110 haoqing0110 force-pushed the br_cel branch 2 times, most recently from 8086c17 to af2bed5 Compare May 12, 2025 09:50
Copy link
Member

@mikeshng mikeshng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just some minor nits.

@haoqing0110
Copy link
Member Author

thanks @mikeshng , all the comments fixed.

Copy link
Member

@mikeshng mikeshng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

/lgtm

Thanks!

Copy link
Contributor

openshift-ci bot commented May 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haoqing0110, mikeshng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit fd8d4e5 into open-cluster-management-io:main May 13, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants