add resourceCleanup featureGate introduction #473
Conversation
✅ Deploy Preview for open-cluster-management ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
zhiweiyin318
force-pushed
the
add-gc
branch
4 times, most recently
from
be5a047 to
add0d9f
Compare
content/en/docs/getting-started/installation/register-a-cluster.md
Outdated
Show resolved
Hide resolved
| @@ -316,3 +316,33 @@ Check the klusterlet is removed from the managed cluster. | |||
| kubectl get klusterlet --context ${CTX_MANAGED_CLUSTER} | |||
| error: the server doesn't have a resource type "klusterlet | |||
| ``` | |||
|
|
|||
| ### ResourceCleanup FeatureGate | |||
|
|
|||
There was a problem hiding this comment.
add a short description that
when the user deletes the managedcluster resource, the related resource under the cluster namespace should also be removed, including managedclusteraddon, manifestworks and the rolebindings for the klusterlet agent. There is a certain sequence for cleanup to ensure no resource will be blocked in the deleting state.
| **Deletion Sequence:** | ||
| 1. managedClusterAddons are deleted first. | ||
| 2. manifestWorks are removed subsequently after there is no managedClusterAddon. | ||
| 3. Custom ordering can be defined using the `open-cluster-management.io/cleanup-priority` annotation: |
There was a problem hiding this comment.
We need to explain why this order is needed, some example use case would be helpful for user the understand.
|
|
||
| 1. managedClusterAddons are deleted first. | ||
| 2. manifestWorks are removed subsequently after all managedClusterAddons are deleted. | ||
| 3. Custom deletion ordering can be defined using the `open-cluster-management.io/cleanup-priority` annotation: |
There was a problem hiding this comment.
also need to clarify which resource the annotation should be added.
Signed-off-by: Zhiwei Yin <[email protected]>
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16, zhiweiyin318 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit ddf9520
into
open-cluster-management-io:main
No description provided.