Fix security issues in workflows #1977
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ZePan110 <[email protected]>
Dependency Review✅ No vulnerabilities or license issues found.Scanned FilesNone |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR tightens workflow permissions by explicitly granting only read access to repository contents across all CI/CD workflows to address security issues.
- Added a
permissions: contents: readblock to each workflow for least-privilege enforcement. - Removed any unsupported
types:filter under push triggers. - Ensured uniform permission settings across scheduled, push, pull_request, and manual workflows.
Reviewed Changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/weekly-example-test.yml | Added minimal permissions: contents: read |
| .github/workflows/push-infra-issue-creation.yml | Added minimal permissions: contents: read |
| .github/workflows/push-images-path-detection.yml | Added minimal permissions: contents: read |
| .github/workflows/push-image-build.yml | Added minimal permissions: contents: read |
| .github/workflows/pr-link-path-scan.yml | Added minimal permissions: contents: read |
| .github/workflows/pr-dockerfile-path-and-build-yaml-scan.yml | Added minimal permissions: contents: read |
| .github/workflows/pr-docker-compose-e2e.yml | Added minimal permissions: contents: read |
| .github/workflows/pr-code-scan.yml | Added minimal permissions: contents: read |
| .github/workflows/pr-check-duplicated-image.yml | Added minimal permissions: contents: read |
| .github/workflows/pr-chart-e2e.yml | Added minimal permissions: contents: read |
| .github/workflows/nightly-docker-build-publish.yml | Added minimal permissions: contents: read |
| .github/workflows/mix-trellix.yml | Added minimal permissions: contents: read |
| .github/workflows/manual-reset-local-registry.yml | Added minimal permissions: contents: read |
| .github/workflows/manual-image-build.yml | Added minimal permissions: contents: read |
| .github/workflows/manual-freeze-tag.yml | Added minimal permissions: contents: read |
| .github/workflows/manual-docker-clean.yml | Added minimal permissions: contents: read |
| .github/workflows/dockerhub-description.yml | Added minimal permissions: contents: read |
| .github/workflows/_gmc-workflow.yml | Added minimal permissions: contents: read |
| .github/workflows/_gmc-e2e.yml | Added minimal permissions: contents: read |
Co-authored-by: Copilot <[email protected]>
Signed-off-by: ZePan110 <[email protected]>
Signed-off-by: ZePan110 <[email protected]>
This reverts commit 2f9959f.
Signed-off-by: ZePan110 <[email protected]>
ZePan110
force-pushed
the
Fix-sec
branch
15 times, most recently
from
383938c to
9911ae9
Compare
Signed-off-by: ZePan110 <[email protected]>
Signed-off-by: ZePan110 <[email protected]>
ZePan110
force-pushed
the
Fix-sec
branch
2 times, most recently
from
54ff8b5 to
dfb41e9
Compare
ZePan110
force-pushed
the
Fix-sec
branch
12 times, most recently
from
ea4b697 to
02c703e
Compare
Signed-off-by: ZePan110 <[email protected]>
Signed-off-by: ZePan110 <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: ZePan110 <[email protected]>
Signed-off-by: ZePan110 <[email protected]>
chensuyue
approved these changes
May 29, 2025
lvliang-intel
approved these changes
May 29, 2025
edlee123
pushed a commit
to edlee123/GenAIExamples
that referenced
this pull request
Jun 5, 2025
Signed-off-by: ZePan110 <[email protected]> Signed-off-by: Ed Lee <[email protected]>
edlee123
pushed a commit
to edlee123/GenAIExamples
that referenced
this pull request
Jun 24, 2025
Signed-off-by: ZePan110 <[email protected]> Signed-off-by: Ed Lee <[email protected]>
alexsin368
pushed a commit
to alexsin368/GenAIExamples
that referenced
this pull request
Aug 13, 2025
Signed-off-by: ZePan110 <[email protected]> Signed-off-by: alexsin368 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix security issues in workflows
Issues
List the issue or RFC link this PR is working on. If there is no such link, please mark it as
n/a.Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
List the newly introduced 3rd party dependency if exists.
Tests
Weekly test all examples on multiple HWs: https://github.com/opea-project/GenAIExamples/actions/runs/15267959880