-
Notifications
You must be signed in to change notification settings - Fork 217
Add Support for Microsoft SQL Server 2025 as a Vector database in Dataprep and Retriever components #1860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Zahidul Haque <[email protected]>
Signed-off-by: Zahidul Haque <[email protected]>
Signed-off-by: Zahidul Haque <[email protected]>
…ervices Signed-off-by: Zahidul Haque <[email protected]>
for more information, see https://pre-commit.ci
letonghan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @zahidulhaque for your great contribution!
Here's some comments, please check and refine, thanks!
Signed-off-by: Zahidul Haque <[email protected]>
Signed-off-by: Zahidul Haque <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: Zahidul Haque <[email protected]>
|
@letonghan Thanks for your review and feedback! I've addressed the comments. Can you please have a look? |
letonghan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @zahidulhaque !
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
|
Thanks @zahidulhaque for your contribution. Could you please help resolve the conflicts? |
Signed-off-by: Zahidul Haque <[email protected]>
|
hi @joshuayao , Thanks for reviewing. Merge conflicts have been resolved. Please check. |
During testing today, I encountered a build failure. The issue stems from the recent upgrade of the base image (python:3.11-slim) used by the dataprep and retrievers components to Debian 13, which was officially released last month. Unfortunately, Microsoft does not yet provide official support for the ODBC Driver for SQL Server on Debian 13. I am currently exploring workarounds to enable compatibility until Microsoft releases an officially supported driver. I will push a fix once I identify a viable solution and validate it end-to-end. |
|
The issue with Debian 13 has been resolved. Please check. |
Thanks. Could you please check the hadolint check failure? |
Signed-off-by: Zahidul Haque <[email protected]>
The hadolint failure issue has been resolved. |
Thanks. Could you please check the CI failures? |
Signed-off-by: Zahidul Haque <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: Zahidul Haque <[email protected]>
Signed-off-by: Zahidul Haque <[email protected]>
Signed-off-by: Zahidul Haque <[email protected]>
51142ef to
e61dd98
Compare
|
I have reviewed the CI failures and it looks like they are not related to the changes I made in this commit. |
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
Description
This PR introduces comprehensive support for Microsoft SQL Server 2025 across multiple components of the GenAIComps and OPEA frameworks. It enables SQL Server as a backend for both the Dataprep and Retriever microservices, with full Docker-based deployment, environment configuration, and embedding support. The integration enhances compatibility with enterprise-grade databases and provides robust documentation for seamless setup and usage.
Key Features
Docker Deployment for SQL Server
compose.yamlundercomps/third_parties/sqlserver/deployment/docker_compose/for containerized SQL Server setup.Documentation Enhancements
README.mdundercomps/third_parties/sqlserver/src/with:MSSQL_SA_PASSWORD)docker runanddocker composeREADME_sqlserver.mdadded to:dataprep/srcretrievers/srcDataprep Microservice Integration
OpeaSqlServerDataprepinintegrations/sqlserver.pySQLServer_VectorStoreopea_dataprep_microservice.pyRetriever Microservice Integration
OpeaSqlServerRetrieverinintegrations/sqlserver.pyopea_retrievers_microservice.pyEnvironment & Configuration
MSSQL_CONNECTION_STRINGTABLE_NAMECHUNK_SIZE,CHUNK_OVERLAPfor embeddingdataprep-sqlserverretriever-sqlserverIssues
NA
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
Added to requirements-cpu.txt:
Dockerfiles updated to install:
Tests
Describe the tests that you ran to verify your changes.