Do not run tests under proxy lib if libumf is not a shared lib #890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not run tests under the proxy library if libumf is not a shared library, because the proxy library is built only if libumf is a shared library. Signed-off-by: Lukasz Dorau <[email protected]>
|
this is a fix for existing fails in CI? |
bratpiorka
approved these changes
Nov 12, 2024
lukaszstolarczuk
approved these changes
Nov 12, 2024
ldorau
deleted the
Do_not_run_tests_under_proxy_lib_if_libumf_is_not_a_shared_lib
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Do not run tests under the proxy library if libumf is not a shared library,
because the proxy library is built only if libumf is a shared library.
ref. #761
Checklist