add names to test cases #1417
Merged
add names to test cases #1417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bratpiorka
force-pushed
the
rrudnick_test_names
branch
3 times, most recently
from
ff1b773 to
56819a9
Compare
KFilipek
requested changes
Jul 7, 2025
bratpiorka
force-pushed
the
rrudnick_test_names
branch
7 times, most recently
from
d0a9cb1 to
3e20354
Compare
bratpiorka
force-pushed
the
rrudnick_test_names
branch
from
3e20354 to
f27926a
Compare
KFilipek
reviewed
Jul 17, 2025
KFilipek
reviewed
Jul 17, 2025
|
if you want this to be included in 1.0.0 please rebase to |
There was a problem hiding this comment.
Pull Request Overview
This PR aims to improve test organization and maintainability by adding descriptive names to test cases and refactoring common functionality. The changes consolidate the providerCreateExt function across multiple test files and reorganize include statements for better structure.
- Move
providerCreateExtfunction to common provider header to eliminate duplication - Reorganize include statements following a consistent pattern (standard libs, external libs, project headers)
- Add name generators to parameterized test suites for better test identification
Reviewed Changes
Copilot reviewed 33 out of 33 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| test/utils/cpp_helpers.hpp | Reorganized include order and added spacing |
| test/common/provider.hpp | Added common providerCreateExt function and name generator |
| test/common/pool.hpp | Added name generator for pool test parameters |
| test/ipcFixtures.hpp | Added name generator for IPC test parameters and getName() method |
| Multiple test files | Updated to use common functions and added test name generators |
|
@lukaszstolarczuk this PR changes only tests so main branch is fine |
bratpiorka
force-pushed
the
rrudnick_test_names
branch
from
f27926a to
9a60344
Compare
bratpiorka
force-pushed
the
rrudnick_test_names
branch
from
9a60344 to
08f7c9b
Compare
lukaszstolarczuk
approved these changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.