-
Notifications
You must be signed in to change notification settings - Fork 37
add names to test cases #1417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add names to test cases #1417
Conversation
ff1b773
to
56819a9
Compare
d0a9cb1
to
3e20354
Compare
3e20354
to
f27926a
Compare
if you want this to be included in 1.0.0 please rebase to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR aims to improve test organization and maintainability by adding descriptive names to test cases and refactoring common functionality. The changes consolidate the providerCreateExt
function across multiple test files and reorganize include statements for better structure.
- Move
providerCreateExt
function to common provider header to eliminate duplication - Reorganize include statements following a consistent pattern (standard libs, external libs, project headers)
- Add name generators to parameterized test suites for better test identification
Reviewed Changes
Copilot reviewed 33 out of 33 changed files in this pull request and generated 5 comments.
Show a summary per file
File | Description |
---|---|
test/utils/cpp_helpers.hpp | Reorganized include order and added spacing |
test/common/provider.hpp | Added common providerCreateExt function and name generator |
test/common/pool.hpp | Added name generator for pool test parameters |
test/ipcFixtures.hpp | Added name generator for IPC test parameters and getName() method |
Multiple test files | Updated to use common functions and added test name generators |
@lukaszstolarczuk this PR changes only tests so main branch is fine |
f27926a
to
9a60344
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
9a60344
to
08f7c9b
Compare
Uh oh!
There was an error while loading. Please reload this page.