Skip to content

add names to test cases #1417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 17, 2025

Conversation

bratpiorka
Copy link
Contributor

@bratpiorka bratpiorka commented Jul 4, 2025

  • make providerCreateExt func common
  • cleanup includes order
  • add names to test cases

@bratpiorka bratpiorka force-pushed the rrudnick_test_names branch 3 times, most recently from ff1b773 to 56819a9 Compare July 7, 2025 07:57
@bratpiorka bratpiorka force-pushed the rrudnick_test_names branch 7 times, most recently from d0a9cb1 to 3e20354 Compare July 14, 2025 13:42
@bratpiorka bratpiorka requested a review from lplewa July 14, 2025 13:43
@bratpiorka bratpiorka force-pushed the rrudnick_test_names branch from 3e20354 to f27926a Compare July 14, 2025 13:52
@bratpiorka bratpiorka marked this pull request as ready for review July 14, 2025 18:23
@bratpiorka bratpiorka requested a review from a team as a code owner July 14, 2025 18:23
@lukaszstolarczuk
Copy link
Contributor

if you want this to be included in 1.0.0 please rebase to v1.0.x branch.

@lukaszstolarczuk lukaszstolarczuk requested a review from Copilot July 17, 2025 12:48
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR aims to improve test organization and maintainability by adding descriptive names to test cases and refactoring common functionality. The changes consolidate the providerCreateExt function across multiple test files and reorganize include statements for better structure.

  • Move providerCreateExt function to common provider header to eliminate duplication
  • Reorganize include statements following a consistent pattern (standard libs, external libs, project headers)
  • Add name generators to parameterized test suites for better test identification

Reviewed Changes

Copilot reviewed 33 out of 33 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
test/utils/cpp_helpers.hpp Reorganized include order and added spacing
test/common/provider.hpp Added common providerCreateExt function and name generator
test/common/pool.hpp Added name generator for pool test parameters
test/ipcFixtures.hpp Added name generator for IPC test parameters and getName() method
Multiple test files Updated to use common functions and added test name generators

@bratpiorka
Copy link
Contributor Author

@lukaszstolarczuk this PR changes only tests so main branch is fine

Copy link
Contributor

@KFilipek KFilipek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bratpiorka bratpiorka force-pushed the rrudnick_test_names branch from 9a60344 to 08f7c9b Compare July 17, 2025 13:26
@lukaszstolarczuk lukaszstolarczuk merged commit 5f277f8 into oneapi-src:main Jul 17, 2025
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants